Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(component): new calendar-view DatePicker #5654

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

CatsJuice
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Jan 22, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

CatsJuice commented Jan 22, 2024

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 206 lines in your changes are missing coverage. Please review.

Comparison is base (876b853) 65.14% compared to head (e664494) 45.50%.

Files Patch % Lines
...mponent/src/ui/date-picker/calendar/day-picker.tsx 1.51% 65 Missing ⚠️
...ponent/src/ui/date-picker/calendar/year-picker.tsx 4.54% 63 Missing ⚠️
...onent/src/ui/date-picker/calendar/month-picker.tsx 3.38% 57 Missing ⚠️
...component/src/ui/date-picker/calendar/calendar.tsx 6.66% 14 Missing ⚠️
...nd/component/src/ui/date-picker/calendar/items.tsx 41.66% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #5654       +/-   ##
===========================================
- Coverage   65.14%   45.50%   -19.65%     
===========================================
  Files         350      225      -125     
  Lines       19690     5246    -14444     
  Branches     1667      927      -740     
===========================================
- Hits        12827     2387    -10440     
+ Misses       6642     2669     -3973     
+ Partials      221      190       -31     
Flag Coverage Δ
server-test ?
unittest 45.50% <18.89%> (-1.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/refactor/date-picker branch from 05f67d4 to 3302770 Compare February 19, 2024 03:59
Copy link

nx-cloud bot commented Feb 19, 2024

@CatsJuice CatsJuice force-pushed the catsjuice/refactor/date-picker branch from 3302770 to 7c46256 Compare February 20, 2024 08:51
Copy link

graphite-app bot commented Feb 20, 2024

Merge activity

@graphite-app graphite-app bot merged commit e664494 into canary Feb 20, 2024
41 of 43 checks passed
@graphite-app graphite-app bot deleted the catsjuice/refactor/date-picker branch February 20, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants