Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): replace page filter, journal's date-picker with new one #5675

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

CatsJuice
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Jan 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

CatsJuice commented Jan 23, 2024

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e664494) 64.55% compared to head (3fe9d83) 64.51%.

Files Patch % Lines
...onent/src/ui/date-picker/calendar/month-picker.tsx 0.00% 2 Missing ⚠️
...ponent/src/ui/date-picker/calendar/year-picker.tsx 0.00% 2 Missing ⚠️
...re/src/components/page-list/filter/date-select.tsx 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5675      +/-   ##
==========================================
- Coverage   64.55%   64.51%   -0.05%     
==========================================
  Files         358      360       +2     
  Lines       19944    19956      +12     
  Branches     1701     1701              
==========================================
- Hits        12875    12874       -1     
- Misses       6848     6863      +15     
+ Partials      221      219       -2     
Flag Coverage Δ
server-test 71.35% <ø> (ø)
unittest 45.37% <53.84%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the test Related to test cases label Jan 23, 2024
@CatsJuice CatsJuice force-pushed the catsjuice/refactor/date-picker branch from 871603a to 8a4dcd8 Compare January 24, 2024 01:54
@CatsJuice CatsJuice force-pushed the catsjuice/refactor/date-picker_replace branch from 2314c9b to 2899d9e Compare January 24, 2024 01:54
@CatsJuice CatsJuice force-pushed the catsjuice/refactor/date-picker_replace branch from 2899d9e to 5d7533f Compare January 24, 2024 02:18
@CatsJuice CatsJuice force-pushed the catsjuice/refactor/date-picker branch from 05f67d4 to 3302770 Compare February 19, 2024 03:59
@CatsJuice CatsJuice force-pushed the catsjuice/refactor/date-picker_replace branch from 5d7533f to 7c1112f Compare February 19, 2024 07:34
Copy link

nx-cloud bot commented Feb 19, 2024

@CatsJuice CatsJuice force-pushed the catsjuice/refactor/date-picker branch from 3302770 to 7c46256 Compare February 20, 2024 08:51
@CatsJuice CatsJuice force-pushed the catsjuice/refactor/date-picker_replace branch from 7c1112f to 43d73ec Compare February 20, 2024 08:51
Copy link

graphite-app bot commented Feb 20, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the catsjuice/refactor/date-picker_replace branch from 43d73ec to 3fe9d83 Compare February 20, 2024 13:54
@Brooooooklyn Brooooooklyn changed the base branch from catsjuice/refactor/date-picker to canary February 20, 2024 14:02
@graphite-app graphite-app bot merged commit 3fe9d83 into canary Feb 20, 2024
34 checks passed
@graphite-app graphite-app bot deleted the catsjuice/refactor/date-picker_replace branch February 20, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants