feat(core): add starAFFiNE and issueFeedback modal #5718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## canary #5718 +/- ##
==========================================
- Coverage 65.16% 65.14% -0.02%
==========================================
Files 348 350 +2
Lines 19670 19689 +19
Branches 1660 1667 +7
==========================================
+ Hits 12817 12826 +9
- Misses 6632 6642 +10
Partials 221 221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JimmFly
force-pushed
the
jimmfly/0125/setting
branch
from
5716ef0
to
cda105d
Compare
CatsJuice
reviewed
Jan 27, 2024
packages/frontend/component/src/components/overlay-modal/overlay-modal.css.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/component/src/components/overlay-modal/overlay-modal.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/component/src/components/overlay-modal/overlay-modal.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/component/src/components/overlay-modal/overlay-modal.tsx
Outdated
Show resolved
Hide resolved
JimmFly
force-pushed
the
jimmfly/0125/setting
branch
from
cda105d
to
763d1ad
Compare
JimmFly
force-pushed
the
jimmfly/0125/setting
branch
2 times, most recently
from
1ab5645
to
721625c
Compare
CatsJuice
reviewed
Jan 28, 2024
packages/frontend/component/src/ui/overlay-modal/overlay-modal.tsx
Outdated
Show resolved
Hide resolved
CatsJuice
reviewed
Jan 28, 2024
packages/frontend/component/src/ui/overlay-modal/overlay-modal.tsx
Outdated
Show resolved
Hide resolved
JimmFly
force-pushed
the
jimmfly/0125/setting
branch
from
620843c
to
3a1ef54
Compare
JimmFly
force-pushed
the
jimmfly/0125/setting
branch
from
3a1ef54
to
8ace0eb
Compare
CatsJuice
reviewed
Jan 29, 2024
packages/frontend/core/src/components/affine/setting-modal/style.css.ts
Outdated
Show resolved
Hide resolved
JimmFly
force-pushed
the
jimmfly/0125/setting
branch
from
8ace0eb
to
fedc7b2
Compare
JimmFly
force-pushed
the
jimmfly/0125/setting
branch
2 times, most recently
from
cdf12a8
to
89297c9
Compare
CatsJuice
approved these changes
Jan 31, 2024
JimmFly
force-pushed
the
jimmfly/0125/setting
branch
3 times, most recently
from
a1da1e0
to
0c982aa
Compare
JimmFly
force-pushed
the
jimmfly/0125/setting
branch
from
0c982aa
to
ef2b48c
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4068e7a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
JimmFly
force-pushed
the
jimmfly/0125/setting
branch
from
ef2b48c
to
64dd09a
Compare
Merge activity
|
Brooooooklyn
pushed a commit
that referenced
this pull request
Feb 20, 2024
Brooooooklyn
force-pushed
the
jimmfly/0125/setting
branch
from
64dd09a
to
3ee8606
Compare
Brooooooklyn
force-pushed
the
jimmfly/0125/setting
branch
from
3ee8606
to
4068e7a
Compare
Brooooooklyn
pushed a commit
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close TOV-482
2024-01-26.3.07.42.mov