Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add history tips modal #5733

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Jan 29, 2024

close TOV-459 TOV-503

2024-01-29.5.12.10.mov

Copy link

graphite-app bot commented Jan 29, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

JimmFly commented Jan 29, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4068e7a) 65.14% compared to head (3792506) 65.23%.
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5733      +/-   ##
==========================================
+ Coverage   65.14%   65.23%   +0.09%     
==========================================
  Files         350      350              
  Lines       19689    19690       +1     
  Branches     1667     1668       +1     
==========================================
+ Hits        12826    12845      +19     
+ Misses       6642     6624      -18     
  Partials      221      221              
Flag Coverage Δ
server-test 71.47% <ø> (+0.12%) ⬆️
unittest 46.85% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/0125/setting_split_history_modal branch from 8025682 to 208dc83 Compare January 29, 2024 07:32
@JimmFly JimmFly force-pushed the jimmfly/0125/setting_split_history_modal branch from 208dc83 to c6dd568 Compare January 29, 2024 09:10
@JimmFly JimmFly force-pushed the jimmfly/0125/setting_split_history_modal branch from c6dd568 to b85d4b6 Compare January 30, 2024 14:21
@JimmFly JimmFly force-pushed the jimmfly/0125/setting_split_history_modal branch from b85d4b6 to 87e384b Compare January 31, 2024 06:29
@JimmFly JimmFly force-pushed the jimmfly/0125/setting_split_history_modal branch 2 times, most recently from 70962d7 to bfb6ed5 Compare January 31, 2024 09:41
@JimmFly JimmFly force-pushed the jimmfly/0125/setting_split_history_modal branch from bfb6ed5 to b6e89a6 Compare February 1, 2024 09:45
@JimmFly JimmFly force-pushed the jimmfly/0125/setting_split_history_modal branch from b6e89a6 to 95f8e95 Compare February 1, 2024 09:58
@JimmFly JimmFly force-pushed the jimmfly/0125/setting_split_history_modal branch from 95f8e95 to 58cabfd Compare February 20, 2024 05:58
Copy link

nx-cloud bot commented Feb 20, 2024

Copy link

graphite-app bot commented Feb 20, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the jimmfly/0125/setting_split_history_modal branch from 466ece0 to 3792506 Compare February 20, 2024 12:51
@Brooooooklyn Brooooooklyn changed the base branch from jimmfly/0125/setting to canary February 20, 2024 13:04
@graphite-app graphite-app bot merged commit 3792506 into canary Feb 20, 2024
34 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0125/setting_split_history_modal branch February 20, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants