Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): journal display on cmdk #5723

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jan 26, 2024

image.png

Copy link

graphite-app bot commented Jan 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Jan 26, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d97304e) 64.61% compared to head (a120eb9) 64.69%.

Files Patch % Lines
.../src/hooks/use-block-suite-workspace-page-title.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5723      +/-   ##
==========================================
+ Coverage   64.61%   64.69%   +0.07%     
==========================================
  Files         358      358              
  Lines       19920    19924       +4     
  Branches     1697     1699       +2     
==========================================
+ Hits        12871    12889      +18     
+ Misses       6830     6816      -14     
  Partials      219      219              
Flag Coverage Δ
server-test 71.57% <ø> (+0.12%) ⬆️
unittest 45.32% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/01-26-fix_core_journal_display_on_cmdk branch from 6512220 to 45ef480 Compare January 26, 2024 10:37
@pengx17 pengx17 requested a review from joooye34 January 29, 2024 06:18
@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from 7b1b292 to 54aab64 Compare January 30, 2024 11:49
@pengx17 pengx17 force-pushed the xp/01-26-fix_core_journal_display_on_cmdk branch from 45ef480 to a2a87c0 Compare January 30, 2024 11:49
@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from 54aab64 to 5d58d7f Compare January 31, 2024 15:20
@pengx17 pengx17 force-pushed the xp/01-26-fix_core_journal_display_on_cmdk branch from a2a87c0 to 705ee09 Compare January 31, 2024 15:20
@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from 5d58d7f to a5cdf9c Compare February 1, 2024 09:07
@pengx17 pengx17 force-pushed the xp/01-26-fix_core_journal_display_on_cmdk branch from 705ee09 to cf0d7b2 Compare February 1, 2024 09:07
@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from a5cdf9c to 4c71f8f Compare February 1, 2024 14:34
@pengx17 pengx17 force-pushed the xp/01-26-fix_core_journal_display_on_cmdk branch from cf0d7b2 to f6d9f35 Compare February 1, 2024 14:34
@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from 4c71f8f to 14fb5dd Compare February 1, 2024 14:44
@pengx17 pengx17 force-pushed the xp/01-26-fix_core_journal_display_on_cmdk branch from f6d9f35 to 927dbb5 Compare February 1, 2024 14:44
@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from 14fb5dd to 9c300da Compare February 2, 2024 10:41
@pengx17 pengx17 force-pushed the xp/01-26-fix_core_journal_display_on_cmdk branch from 927dbb5 to aaa2c8a Compare February 2, 2024 10:41
@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from 9c300da to b6f211f Compare February 13, 2024 14:37
@pengx17 pengx17 force-pushed the xp/01-26-fix_core_journal_display_on_cmdk branch from aaa2c8a to 433bcf5 Compare February 13, 2024 14:37
Copy link

nx-cloud bot commented Feb 13, 2024

@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from b6f211f to f70e4f7 Compare February 16, 2024 13:08
@pengx17 pengx17 force-pushed the xp/01-26-fix_core_journal_display_on_cmdk branch from 433bcf5 to 25bf5e3 Compare February 16, 2024 13:09
@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from f70e4f7 to d1c4e61 Compare February 16, 2024 13:20
@pengx17 pengx17 changed the base branch from xp/01-26-refactor_component_cmdk_ordering to canary February 16, 2024 13:28
@pengx17 pengx17 force-pushed the xp/01-26-fix_core_journal_display_on_cmdk branch from 25bf5e3 to 74e7563 Compare February 22, 2024 03:54
Copy link

graphite-app bot commented Feb 22, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the xp/01-26-fix_core_journal_display_on_cmdk branch from 74e7563 to a120eb9 Compare February 22, 2024 06:09
@graphite-app graphite-app bot merged commit a120eb9 into canary Feb 22, 2024
40 of 42 checks passed
@graphite-app graphite-app bot deleted the xp/01-26-fix_core_journal_display_on_cmdk branch February 22, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants