fix(core): prevent data loss (hot-fix) #5798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
mod:infra
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a1cc4b1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
EYHN
changed the title
EYHN
force-pushed
the
eyhn/fix/data-lose
branch
from
43a9b36
to
a1cc4b1
Compare
Brooooooklyn
approved these changes
Feb 5, 2024
pengx17
reviewed
Feb 5, 2024
| @@ -67,12 +73,34 @@ export const Component = (): ReactElement => { | |||
| localStorage.setItem('last_workspace_id', workspace.id); | |||
| }, [setCurrentWorkspace, meta, workspaceManager, workspace]); | |||
|
|
|||
| const [workspaceIsLoading, setWorkspaceIsLoading] = useState(true); | |||
|
|
|||
| // hotfix: avoid doing operation, before workspace is loaded | |||
There was a problem hiding this comment.
maybe combine this with doc.whenSynced?
Brooooooklyn
pushed a commit
that referenced
this pull request
Feb 5, 2024
Brooooooklyn
added a commit
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.