Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): prevent data loss (hot-fix) (#5798) #5800

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

Brooooooklyn
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Feb 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

Copy link

nx-cloud bot commented Feb 5, 2024

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9c2dc8) 64.92% compared to head (51680da) 46.57%.

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #5800       +/-   ##
===========================================
- Coverage   64.92%   46.57%   -18.36%     
===========================================
  Files         345      214      -131     
  Lines       19597     4913    -14684     
  Branches     1651      875      -776     
===========================================
- Hits        12723     2288    -10435     
+ Misses       6656     2438     -4218     
+ Partials      218      187       -31     
Flag Coverage Δ
server-test ?
unittest 46.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@EYHN EYHN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

graphite-app bot commented Feb 5, 2024

Merge activity

@graphite-app graphite-app bot merged commit 51680da into canary Feb 5, 2024
38 of 42 checks passed
@graphite-app graphite-app bot deleted the hotfix/cherry-pick-5798 branch February 5, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants