Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: blocksuite integration for pageMode & pageUpdatedAt #5849

Merged

Conversation

AyushAgrawal-A2
Copy link
Contributor

@AyushAgrawal-A2 AyushAgrawal-A2 commented Feb 20, 2024

Changes:

  • Added integration for pageMode and pageUpdatedAt, required for linked / synced doc block.

  • Added linkPreviewUrl for embed github, youtube & loom

  • Fixed imageProxyUrl config for clipboard middleware. Due to missing editor.updateComplete for onLoad function,
    AFFiNE's imageProxyUrl -/api/worker/image-proxy was never getting set before. Hence all proxy requests were going to the default proxy url in blocksuite - https://affine-worker.toeverything.workers.dev/api/worker/image-proxy.
    before:
    image

    after:
    image

P.S.:

  1. There was a bug in blocksuite, where proxy fetch was missing response.ok check. This is fixed in fix(page): correct image fetch via proxy with response.ok check blocksuite#6251 and requires blocksuite bump for tests to pass.
  2. Recent change in affine-worker regarding image proxy can be reverted, if required, as now with correct proxy config requests will not go to https://affine-worker.toeverything.workers.dev/api/worker/image-proxy for local dev / tests. cc @darkskygit

Copy link

nx-cloud bot commented Feb 20, 2024

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (53b312c) 64.60% compared to head (2a7ca32) 64.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5849      +/-   ##
==========================================
- Coverage   64.60%   64.51%   -0.10%     
==========================================
  Files         360      360              
  Lines       19956    19956              
  Branches     1702     1701       -1     
==========================================
- Hits        12892    12874      -18     
- Misses       6845     6863      +18     
  Partials      219      219              
Flag Coverage Δ
server-test 71.35% <ø> (-0.13%) ⬇️
unittest 45.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brooooooklyn Brooooooklyn merged commit 11b3184 into toeverything:canary Feb 21, 2024
32 of 34 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/pageInfoIntegration branch February 21, 2024 07:04
Brooooooklyn added a commit that referenced this pull request Feb 21, 2024
Co-authored-by: LongYinan <lynweklm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants