Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(page): correct image fetch via proxy with response.ok check #6251

Merged

Conversation

AyushAgrawal-A2
Copy link
Contributor

Changes:

  • Added response.ok check for image fetch via proxy, as fetch does not throw error for non-200 statuses.

Linked with toeverything/AFFiNE#5849

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 8:05pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 8:05pm

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@doodlewind doodlewind merged commit 789aa2b into toeverything:master Feb 20, 2024
20 checks passed
fundon pushed a commit to fundon/blocksuite that referenced this pull request Feb 21, 2024
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/imageProxyFetch branch February 21, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants