Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(electron): add isMaximized flag to html #6199

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 19, 2024

to make some special ui rules for desktop

Copy link

graphite-app bot commented Mar 19, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 19, 2024

@github-actions github-actions bot added app:electron Related to electron app app:core labels Mar 19, 2024
@pengx17 pengx17 marked this pull request as ready for review March 19, 2024 10:09
Copy link

nx-cloud bot commented Mar 19, 2024

@pengx17 pengx17 requested review from CatsJuice and EYHN March 19, 2024 10:12
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.85%. Comparing base (65ab6c8) to head (a8a1074).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6199      +/-   ##
==========================================
+ Coverage   60.77%   60.85%   +0.07%     
==========================================
  Files         509      506       -3     
  Lines       22965    22962       -3     
  Branches     2075     2076       +1     
==========================================
+ Hits        13957    13973      +16     
+ Misses       8755     8737      -18     
+ Partials      253      252       -1     
Flag Coverage Δ
server-test 70.95% <ø> (+0.12%) ⬆️
unittest 39.01% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/03-19-feat_electron_add_ismaximized_flag_to_html branch from de037fa to bf37836 Compare March 20, 2024 07:52
Copy link

graphite-app bot commented Mar 20, 2024

Merge activity

to make some special ui rules for desktop
@pengx17 pengx17 force-pushed the xp/03-19-feat_electron_add_ismaximized_flag_to_html branch from bf37836 to a8a1074 Compare March 20, 2024 13:20
@graphite-app graphite-app bot merged commit a8a1074 into canary Mar 20, 2024
39 of 41 checks passed
@graphite-app graphite-app bot deleted the xp/03-19-feat_electron_add_ismaximized_flag_to_html branch March 20, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants