Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): menu item position on Mac when fullscreen #6200

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 19, 2024

fix #6155

Copy link

graphite-app bot commented Mar 19, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 19, 2024

Copy link

nx-cloud bot commented Mar 19, 2024

@pengx17 pengx17 marked this pull request as ready for review March 19, 2024 10:09
@pengx17 pengx17 changed the title feat(electron): some issues related to electron's traffic lights fix(electron): menu item position on Mac when fullscreen Mar 19, 2024
@pengx17 pengx17 requested review from CatsJuice and EYHN March 19, 2024 10:12
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.85%. Comparing base (3edf32b) to head (08b610b).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6200   +/-   ##
=======================================
  Coverage   60.85%   60.85%           
=======================================
  Files         508      508           
  Lines       22964    22964           
  Branches     2076     2076           
=======================================
  Hits        13974    13974           
  Misses       8737     8737           
  Partials      253      253           
Flag Coverage Δ
server-test 70.94% <ø> (ø)
unittest 39.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/03-19-feat_electron_add_ismaximized_flag_to_html branch from de037fa to bf37836 Compare March 20, 2024 07:52
@pengx17 pengx17 force-pushed the xp/03-19-feat_electron_some_issues_related_to_electron_s_traffic_lights branch from 83bdeca to a66d7d7 Compare March 20, 2024 07:52
@pengx17 pengx17 force-pushed the xp/03-19-feat_electron_add_ismaximized_flag_to_html branch from bf37836 to a8a1074 Compare March 20, 2024 13:20
@pengx17 pengx17 changed the base branch from xp/03-19-feat_electron_add_ismaximized_flag_to_html to canary March 20, 2024 13:30
Copy link

graphite-app bot commented Mar 20, 2024

Merge activity

@EYHN EYHN force-pushed the xp/03-19-feat_electron_some_issues_related_to_electron_s_traffic_lights branch from a66d7d7 to 08b610b Compare March 20, 2024 16:45
@graphite-app graphite-app bot merged commit 08b610b into canary Mar 20, 2024
39 of 41 checks passed
@graphite-app graphite-app bot deleted the xp/03-19-feat_electron_some_issues_related_to_electron_s_traffic_lights branch March 20, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

The position of menubar icon when unfolding is not correct, comparing to the web version​
2 participants