Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): save user habits in right sidebar #6262

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 21, 2024

Closes #6237

Copy link

graphite-app bot commented Mar 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Contributor Author

fundon commented Mar 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 21, 2024

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 60.77%. Comparing base (85ee223) to head (7535586).

Files Patch % Lines
...rc/modules/right-sidebar/entities/right-sidebar.ts 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6262      +/-   ##
==========================================
- Coverage   60.77%   60.77%   -0.01%     
==========================================
  Files         509      508       -1     
  Lines       22966    22968       +2     
  Branches     2075     2075              
==========================================
  Hits        13958    13958              
- Misses       8755     8757       +2     
  Partials      253      253              
Flag Coverage Δ
server-test 70.83% <ø> (ø)
unittest 39.02% <14.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/feat/save-user-habits-in-right-sidebar branch from 4722f63 to 0fc6739 Compare March 21, 2024 20:02
@fundon fundon marked this pull request as ready for review March 21, 2024 20:24
@fundon fundon requested a review from EYHN March 21, 2024 20:24
@fundon fundon force-pushed the fundon/feat/save-user-habits-in-right-sidebar branch 2 times, most recently from 5b7303f to de8332b Compare March 22, 2024 02:21
@fundon fundon force-pushed the fundon/feat/save-user-habits-in-right-sidebar branch 3 times, most recently from 0a8a742 to 315dbd2 Compare March 22, 2024 05:28
@fundon fundon requested a review from EYHN March 22, 2024 05:29
@fundon fundon force-pushed the fundon/feat/save-user-habits-in-right-sidebar branch 2 times, most recently from 196c3da to 462dea6 Compare March 22, 2024 05:41
@fundon fundon force-pushed the fundon/feat/save-user-habits-in-right-sidebar branch 3 times, most recently from eba55f6 to 4389814 Compare March 22, 2024 05:56
Copy link

graphite-app bot commented Mar 22, 2024

Merge activity

@EYHN EYHN force-pushed the fundon/feat/save-user-habits-in-right-sidebar branch from 4389814 to 7535586 Compare March 22, 2024 07:33
@graphite-app graphite-app bot merged commit 7535586 into canary Mar 22, 2024
36 of 41 checks passed
@graphite-app graphite-app bot deleted the fundon/feat/save-user-habits-in-right-sidebar branch March 22, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remember state of right sidebar
2 participants