Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open in chat does not work when the panel is not opened #6703

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Apr 25, 2024

#6503 does not work with "open in chat".
IMO resetting tab whenever opening right panel does not make too much sense. @zanwei

fix AFF-951

Copy link

graphite-app bot commented Apr 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Apr 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 requested a review from EYHN April 25, 2024 12:05
@pengx17 pengx17 requested review from JimmFly and zanwei April 25, 2024 12:05
@pengx17 pengx17 marked this pull request as ready for review April 25, 2024 12:05
Copy link

nx-cloud bot commented Apr 25, 2024

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.29%. Comparing base (5b5c27b) to head (cc17d32).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6703   +/-   ##
=======================================
  Coverage   61.29%   61.29%           
=======================================
  Files         586      586           
  Lines       26930    26930           
  Branches     2358     2358           
=======================================
  Hits        16508    16508           
  Misses      10140    10140           
  Partials      282      282           
Flag Coverage Δ
server-test 69.92% <ø> (ø)
unittest 41.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN
Copy link
Member

EYHN commented Apr 26, 2024

I feel we've been changed this over and over again.

#6262

Copy link
Collaborator Author

pengx17 commented Apr 26, 2024

I feel we've been changed this over and over again.

#6262

Saved state clearly conflicts with opening default tab by the doc type. 🤔

Copy link

graphite-app bot commented Apr 26, 2024

Merge activity

  • Apr 25, 10:28 PM EDT: EYHN added this pull request to the Graphite merge queue.
  • Apr 25, 10:39 PM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Desktop Test (macos-14, macos, arm64, aarch64-apple-darwin, true)').
  • Apr 25, 11:49 PM EDT: EYHN added this pull request to the Graphite merge queue.
  • Apr 26, 12:02 AM EDT: EYHN merged this pull request with the Graphite merge queue.

EYHN pushed a commit that referenced this pull request Apr 26, 2024
#6503 does not work with "open in chat".
IMO resetting tab whenever opening right panel does not make too much sense. @zanwei

fix AFF-951
@EYHN EYHN force-pushed the 04-25-fix_open_in_chat_does_not_work_when_the_panel_is_not_opened branch from b3b6712 to c6dea93 Compare April 26, 2024 02:30
#6503 does not work with "open in chat".
IMO resetting tab whenever opening right panel does not make too much sense. @zanwei

fix AFF-951
@EYHN EYHN force-pushed the 04-25-fix_open_in_chat_does_not_work_when_the_panel_is_not_opened branch from c6dea93 to cc17d32 Compare April 26, 2024 03:51
@graphite-app graphite-app bot merged commit cc17d32 into canary Apr 26, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 04-25-fix_open_in_chat_does_not_work_when_the_panel_is_not_opened branch April 26, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants