Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow collections to be added to favorites #6288

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 24, 2024

No description provided.

Copy link

graphite-app bot commented Mar 24, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 24, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 24, 2024

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 62.00%. Comparing base (5f75355) to head (bb1a64b).

Files Patch % Lines
...d/core/src/modules/workspace/properties/adapter.ts 0.00% 11 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                            @@
##           03-24-refactor_core_favorited_adapter    #6288      +/-   ##
=========================================================================
- Coverage                                  62.10%   62.00%   -0.11%     
=========================================================================
  Files                                        514      514              
  Lines                                      23793    23803      +10     
  Branches                                    2266     2266              
=========================================================================
- Hits                                       14776    14758      -18     
- Misses                                      8754     8782      +28     
  Partials                                     263      263              
Flag Coverage Δ
server-test 73.91% <ø> (-0.12%) ⬇️
unittest 38.04% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from 347e782 to 4f00448 Compare March 25, 2024 03:32
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 8d34903 to 9cbcc54 Compare March 25, 2024 03:32
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from 4f00448 to dde5196 Compare March 25, 2024 03:52
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 9cbcc54 to 453b70c Compare March 25, 2024 03:52
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from dde5196 to 6292737 Compare March 25, 2024 06:37
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch 2 times, most recently from 9f36444 to a963b61 Compare March 25, 2024 07:01
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from 6292737 to ab085b6 Compare March 25, 2024 07:21
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from a963b61 to 7c8ec8a Compare March 25, 2024 07:21
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from ab085b6 to 410976e Compare March 25, 2024 07:31
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 7c8ec8a to ac557ce Compare March 25, 2024 07:31
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from 410976e to 4dc0cec Compare March 25, 2024 09:06
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from ac557ce to bbd6660 Compare March 25, 2024 09:06
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from 4dc0cec to afaf2b3 Compare March 25, 2024 10:14
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from bbd6660 to 89918ae Compare March 25, 2024 10:14
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from afaf2b3 to a6bc15c Compare March 25, 2024 10:25
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 89918ae to 82edd7c Compare March 25, 2024 10:25
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from a6bc15c to 076347c Compare March 26, 2024 04:06
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 82edd7c to 866b222 Compare March 26, 2024 04:06
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from 076347c to 3068874 Compare March 26, 2024 06:13
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 866b222 to 21b81cb Compare March 26, 2024 06:13
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from 3068874 to 81fc91d Compare March 26, 2024 06:15
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 21b81cb to b5e467b Compare March 26, 2024 06:15
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from b5e467b to adec96d Compare March 26, 2024 10:53
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from 760e9ce to fbe4489 Compare March 26, 2024 10:54
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from adec96d to d8a82c4 Compare March 26, 2024 10:54
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from fbe4489 to b0e11c3 Compare March 27, 2024 09:18
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from d8a82c4 to a3ce4cc Compare March 27, 2024 09:18
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from b0e11c3 to a6321f0 Compare March 27, 2024 10:47
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from a3ce4cc to 6bdfb0a Compare March 27, 2024 10:47
@pengx17 pengx17 marked this pull request as ready for review March 27, 2024 13:55
@pengx17 pengx17 requested a review from EYHN March 27, 2024 13:57
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from a6321f0 to 8a7f964 Compare March 28, 2024 02:02
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 6bdfb0a to fd89483 Compare March 28, 2024 02:02
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from 8a7f964 to 81440b4 Compare March 28, 2024 03:48
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from fd89483 to c82bdb3 Compare March 28, 2024 03:48
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from 81440b4 to c1b8b00 Compare March 28, 2024 05:11
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from c82bdb3 to ef6dc9f Compare March 28, 2024 05:11
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from c1b8b00 to a785da2 Compare March 28, 2024 08:28
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from ef6dc9f to 17d8ad8 Compare March 28, 2024 08:28
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from a785da2 to 207dd7c Compare March 28, 2024 08:32
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 17d8ad8 to a933578 Compare March 28, 2024 08:32
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from 207dd7c to f757b5d Compare March 28, 2024 10:42
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from a933578 to 187f078 Compare March 28, 2024 10:42
@pengx17 pengx17 force-pushed the 03-24-refactor_core_favorited_adapter branch from f757b5d to 5f75355 Compare March 29, 2024 02:42
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 187f078 to bb1a64b Compare March 29, 2024 02:42
Copy link

graphite-app bot commented Mar 29, 2024

Merge activity

  • Mar 28, 11:58 PM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Mar 29, 12:00 AM EDT: CI is running for this PR on a draft PR: #6391
  • Mar 29, 12:05 AM EDT: CI is running for this PR on a draft PR: #6394
  • Mar 29, 12:18 AM EDT: pengx17 merged this pull request with the Graphite merge queue via draft PR: #6394.

@graphite-app graphite-app bot closed this Mar 29, 2024
@graphite-app graphite-app bot deleted the 03-24-feat_allow_collections_to_be_added_to_favorites branch March 29, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants