Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): fav item reordering #6302

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 25, 2024

No description provided.

Copy link

graphite-app bot commented Mar 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 25, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 25, 2024

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 61.99%. Comparing base (bb1a64b) to head (061eca5).

Files Patch % Lines
...es/frontend/core/src/modules/collection/service.ts 0.00% 3 Missing ⚠️
...d/core/src/modules/workspace/properties/adapter.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                    Coverage Diff                                    @@
##           03-24-feat_allow_collections_to_be_added_to_favorites    #6302      +/-   ##
=========================================================================================
- Coverage                                                  62.00%   61.99%   -0.01%     
=========================================================================================
  Files                                                        514      514              
  Lines                                                      23803    23806       +3     
  Branches                                                    2266     2266              
=========================================================================================
  Hits                                                       14758    14758              
- Misses                                                      8782     8785       +3     
  Partials                                                     263      263              
Flag Coverage Δ
server-test 73.91% <ø> (ø)
unittest 38.03% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 89918ae to 82edd7c Compare March 25, 2024 10:25
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from 8d00e0e to 80b260f Compare March 25, 2024 10:25
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 82edd7c to 866b222 Compare March 26, 2024 04:06
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from 80b260f to 6ba6157 Compare March 26, 2024 04:06
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 866b222 to 21b81cb Compare March 26, 2024 06:13
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from 6ba6157 to b41013d Compare March 26, 2024 06:13
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 21b81cb to b5e467b Compare March 26, 2024 06:15
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from b41013d to 613854e Compare March 26, 2024 06:15
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from b5e467b to adec96d Compare March 26, 2024 10:53
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from 613854e to d510981 Compare March 26, 2024 10:53
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from adec96d to d8a82c4 Compare March 26, 2024 10:54
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch 6 times, most recently from 3ca648d to e733840 Compare March 27, 2024 04:58
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from d8a82c4 to a3ce4cc Compare March 27, 2024 09:18
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch 3 times, most recently from eb0cc9c to a50eb0c Compare March 27, 2024 10:37
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from a3ce4cc to 6bdfb0a Compare March 27, 2024 10:47
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from a50eb0c to 6459a0f Compare March 27, 2024 10:47
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from 62b9e2c to 1c34d3f Compare March 27, 2024 13:55
@github-actions github-actions bot added the test Related to test cases label Mar 27, 2024
@pengx17 pengx17 marked this pull request as ready for review March 27, 2024 13:55
@pengx17 pengx17 requested review from EYHN and JimmFly March 27, 2024 13:57
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 6bdfb0a to fd89483 Compare March 28, 2024 02:02
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from 1c34d3f to f90aa0d Compare March 28, 2024 02:02
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from fd89483 to c82bdb3 Compare March 28, 2024 03:48
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from f90aa0d to ca6b5d0 Compare March 28, 2024 03:48
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from c82bdb3 to ef6dc9f Compare March 28, 2024 05:11
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from ca6b5d0 to 152260b Compare March 28, 2024 05:11
@JimmFly
Copy link
Member

JimmFly commented Mar 28, 2024

Please fix the test

@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from ef6dc9f to 17d8ad8 Compare March 28, 2024 08:28
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from 152260b to b003dc7 Compare March 28, 2024 08:28
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 17d8ad8 to a933578 Compare March 28, 2024 08:32
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from e5a6e42 to a04b0e3 Compare March 28, 2024 08:32
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from a933578 to 187f078 Compare March 28, 2024 10:42
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from a04b0e3 to 1d93fa5 Compare March 28, 2024 10:42
@pengx17 pengx17 force-pushed the 03-24-feat_allow_collections_to_be_added_to_favorites branch from 187f078 to bb1a64b Compare March 29, 2024 02:42
@pengx17 pengx17 force-pushed the xp/03-25-feat_core_fav_item_reordering branch from 1d93fa5 to 061eca5 Compare March 29, 2024 02:42
Copy link

graphite-app bot commented Mar 29, 2024

Merge activity

  • Mar 28, 11:58 PM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Mar 29, 12:00 AM EDT: CI is running for this PR on a draft PR: #6392
  • Mar 29, 12:05 AM EDT: CI is running for this PR on a draft PR: #6395
  • Mar 29, 12:18 AM EDT: pengx17 merged this pull request with the Graphite merge queue via draft PR: #6395.

pengx17 added a commit that referenced this pull request Mar 29, 2024
pengx17 added a commit that referenced this pull request Mar 29, 2024
@graphite-app graphite-app bot closed this Mar 29, 2024
@graphite-app graphite-app bot deleted the xp/03-25-feat_core_fav_item_reordering branch March 29, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants