-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump up sinon version to v18 #6950
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ad09bb6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #6950 +/- ##
=======================================
Coverage 66.58% 66.58%
=======================================
Files 582 582
Lines 27392 27392
Branches 2572 2572
=======================================
Hits 18238 18238
Misses 8884 8884
Partials 270 270
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merge activity
|
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^17.0.1` -> `^18.0.0`](https://renovatebot.com/diffs/npm/sinon/17.0.1/18.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/sinon/18.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/sinon/18.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/sinon/17.0.1/18.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/sinon/17.0.1/18.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon (sinon)</summary> ### [`v18.0.0`](https://togithub.com/sinonjs/sinon/compare/v17.0.2...v18.0.0) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v17.0.2...v18.0.0) ### [`v17.0.2`](https://togithub.com/sinonjs/sinon/blob/HEAD/CHANGES.md#1702) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v17.0.1...v17.0.2) - [`f6dca0ba`](https://togithub.com/sinonjs/sinon/commit/f6dca0bac3f228fa917165eca8815d5e2b8a6793) upgrade packages ([#​2595](https://togithub.com/sinonjs/sinon/issues/2595)) (Carl-Erik Kopseng) - [`5025d001`](https://togithub.com/sinonjs/sinon/commit/5025d001401091fd2086cfa2ec69e40cc0da9b65) Avoid return and callArg\* clearing each other's state ([#​2593](https://togithub.com/sinonjs/sinon/issues/2593)) (Carl-Erik Kopseng) > - Partially revert "fix returns does not override call through ([#​2567](https://togithub.com/sinonjs/sinon/issues/2567))" > > <!----> > > - revert to the old manual clearing of props - [`ed068a88`](https://togithub.com/sinonjs/sinon/commit/ed068a886fa37cbd5f886d355824debd69aa1b16) Bump ip from 1.1.8 to 1.1.9 ([#​2587](https://togithub.com/sinonjs/sinon/issues/2587)) (dependabot\[bot]) - [`ec4d592e`](https://togithub.com/sinonjs/sinon/commit/ec4d592ee4faf87d7e592c4b99b3e6fec99105c8) fix [#​2589](https://togithub.com/sinonjs/sinon/issues/2589): avoid invoking getter as side-effect ([#​2592](https://togithub.com/sinonjs/sinon/issues/2592)) (Carl-Erik Kopseng) - [`9972e1e3`](https://togithub.com/sinonjs/sinon/commit/9972e1e3997198ff7f403ca5c000187f890f1699) Fix typo in mocks documentation ([#​2591](https://togithub.com/sinonjs/sinon/issues/2591)) (Eduardo de la Cruz Palacios) - [`52e6e4c5`](https://togithub.com/sinonjs/sinon/commit/52e6e4c540d8d0b95727c9bbde8328f6692a6675) chore: prefer cache option of setup-node (Morgan Roderick) - [`08da1235`](https://togithub.com/sinonjs/sinon/commit/08da123555dc4ee4866720c925215dca4d3c799b) Bump actions/cache from 3 to 4 (dependabot\[bot]) - [`404ef47e`](https://togithub.com/sinonjs/sinon/commit/404ef47e1119c7b8229e9d6a3c6ae9a912305d1f) Bump nokogiri from 1.14.3 to 1.16.2 (dependabot\[bot]) - [`fd79612c`](https://togithub.com/sinonjs/sinon/commit/fd79612c3324bf3264533baa7159bb1722dd9788) Update Bug_report.md (Carl-Erik Kopseng) - [`1fbc812a`](https://togithub.com/sinonjs/sinon/commit/1fbc812a9f3351f55a06758bdc8b1a053135d826) Re-add about (Carl-Erik Kopseng) - [`fc8f6c3e`](https://togithub.com/sinonjs/sinon/commit/fc8f6c3e111473fcb53b2338eb8654b256c06e01) Fix formatting :clown: (Carl-Erik Kopseng) - [`c57e38ae`](https://togithub.com/sinonjs/sinon/commit/c57e38ae2ec6c466f83c4e38e85d3d324f72bb13) Remove old template (Carl-Erik Kopseng) - [`754bf7a9`](https://togithub.com/sinonjs/sinon/commit/754bf7a98b54a01472677772c7a34859f483adeb) Update Bug_report.md (Carl-Erik Kopseng) - [`87eed9d2`](https://togithub.com/sinonjs/sinon/commit/87eed9d255e9493b981494188abd12a9e1d95bf0) Fix some typos at code comments ([#​2581](https://togithub.com/sinonjs/sinon/issues/2581)) (EliyahuMachluf) - [`cbae6997`](https://togithub.com/sinonjs/sinon/commit/cbae69978c29d0420fa39d11496bb29b180361b0) Link to createStubInstance util.md docs in stubs.md ([#​2577](https://togithub.com/sinonjs/sinon/issues/2577)) (Daniel Kaplan) - [`adcf936d`](https://togithub.com/sinonjs/sinon/commit/adcf936de0e946e2b72a513436c0469319f3da79) Fix Mocha watch task by delegating to Node ([#​2573](https://togithub.com/sinonjs/sinon/issues/2573)) (Carl-Erik Kopseng) - [`30ad2372`](https://togithub.com/sinonjs/sinon/commit/30ad23729568d70f865a5e6d323109fd06c7913e) prettier:write (Carl-Erik Kopseng) - [`45c4d6b9`](https://togithub.com/sinonjs/sinon/commit/45c4d6b9b80841947d6ebc4af5046a11b216d598) Remove outdated info from README ([#​2571](https://togithub.com/sinonjs/sinon/issues/2571)) (Carl-Erik Kopseng) - [`6c9f5c2a`](https://togithub.com/sinonjs/sinon/commit/6c9f5c2ade9befeadd6fd7d10232883c147a9f1d) Add a notice that the Fake Timers API doc is incomplete ([#​2570](https://togithub.com/sinonjs/sinon/issues/2570)) (Carl-Erik Kopseng) - [`93db3ef3`](https://togithub.com/sinonjs/sinon/commit/93db3ef3b0b49458954eb6e7ed765aa1ea34b21d) breaking: Remove sinon.defaultConfig and related modules ([#​2565](https://togithub.com/sinonjs/sinon/issues/2565)) (Carl-Erik Kopseng) > - breaking: Remove sinon.defaultConfig and related modules > > default-config and get-config are leftovers from when Sinon > > shipped with sinon.test (now the independent NPM module > > 'sinon-test'). *Released by [Carl-Erik Kopseng](https://togithub.com/fatso83) on 2024-05-07.* </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5IiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->
89e11ad
to
ad09bb6
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
^17.0.1
->^18.0.0
Release Notes
sinonjs/sinon (sinon)
v18.0.0
Compare Source
v17.0.2
Compare Source
f6dca0ba
upgrade packages (#2595) (Carl-Erik Kopseng)
5025d001
Avoid return and callArg* clearing each other's state (#2593) (Carl-Erik Kopseng)
ed068a88
Bump ip from 1.1.8 to 1.1.9 (#2587) (dependabot[bot])
ec4d592e
fix #2589: avoid invoking getter as side-effect (#2592) (Carl-Erik Kopseng)
9972e1e3
Fix typo in mocks documentation (#2591) (Eduardo de la Cruz Palacios)
52e6e4c5
chore: prefer cache option of setup-node (Morgan Roderick)
08da1235
Bump actions/cache from 3 to 4 (dependabot[bot])
404ef47e
Bump nokogiri from 1.14.3 to 1.16.2 (dependabot[bot])
fd79612c
Update Bug_report.md (Carl-Erik Kopseng)
1fbc812a
Re-add about (Carl-Erik Kopseng)
fc8f6c3e
Fix formatting :clown: (Carl-Erik Kopseng)
c57e38ae
Remove old template (Carl-Erik Kopseng)
754bf7a9
Update Bug_report.md (Carl-Erik Kopseng)
87eed9d2
Fix some typos at code comments (#2581) (EliyahuMachluf)
cbae6997
Link to createStubInstance util.md docs in stubs.md (#2577) (Daniel Kaplan)
adcf936d
Fix Mocha watch task by delegating to Node (#2573) (Carl-Erik Kopseng)
30ad2372
prettier:write (Carl-Erik Kopseng)
45c4d6b9
Remove outdated info from README (#2571) (Carl-Erik Kopseng)
6c9f5c2a
Add a notice that the Fake Timers API doc is incomplete (#2570) (Carl-Erik Kopseng)
93db3ef3
breaking: Remove sinon.defaultConfig and related modules (#2565) (Carl-Erik Kopseng)
Released by Carl-Erik Kopseng on 2024-05-07.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.