chore: adjust padding of ask ai panel #7287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b99e8b1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #7287 +/- ##
==========================================
- Coverage 58.32% 58.28% -0.05%
==========================================
Files 838 838
Lines 36551 36551
Branches 3920 3919 -1
==========================================
- Hits 21320 21302 -18
- Misses 14938 14956 +18
Partials 293 293
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fundon
reviewed
Jun 20, 2024
packages/frontend/core/src/blocksuite/presets/ai/_common/components/ask-ai-panel.ts
Outdated
Show resolved
Hide resolved
L-Sun
added a commit
to toeverything/blocksuite
that referenced
this pull request
Jun 20, 2024
Related: [AF-928](https://linear.app/affine-design/issue/AF-928/ask-ai-出现在底部的时候-menu-弹出位置不对#comment-33f1e925) Considering the space occupied by the scrollbar, adjust the padding of the menu to make it symmetric on both sides, which also ensure the correct pop-up position of the submenu. The affected components include: - Edgeless Mode Ask AI panel - Slash Menu - Page Mode Ask AI panel ( [PR on AFFiNE side](toeverything/AFFiNE#7287) ) 
L-Sun
force-pushed
the
06-20-chore_adjust_padding_of_ask_ai_panel
branch
from
8e08cf9
to
685ee59
Compare
fundon
approved these changes
Jun 20, 2024
Merge activity
|
forehalo
pushed a commit
that referenced
this pull request
Jun 20, 2024
forehalo
force-pushed
the
06-20-chore_adjust_padding_of_ask_ai_panel
branch
from
685ee59
to
9b92534
Compare
L-Sun
force-pushed
the
06-20-chore_adjust_padding_of_ask_ai_panel
branch
from
9b92534
to
b99e8b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: toeverything/blocksuite#7389