Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump blocksuite #7298

Merged
merged 1 commit into from
Jun 21, 2024
Merged

feat: bump blocksuite #7298

merged 1 commit into from
Jun 21, 2024

Conversation

akumatus
Copy link
Member

@akumatus akumatus commented Jun 21, 2024

Copy link

graphite-app bot commented Jun 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

akumatus commented Jun 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @akumatus and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:env mod:component app:electron Related to electron app mod:dev app:core labels Jun 21, 2024
@akumatus akumatus marked this pull request as ready for review June 21, 2024 06:33
@graphite-app graphite-app bot requested review from JimmFly, EYHN and forehalo and removed request for JimmFly June 21, 2024 06:33
Copy link

nx-cloud bot commented Jun 21, 2024

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.96%. Comparing base (1dc254a) to head (f85a321).

Files Patch % Lines
.../block-suite-editor/specs/custom/spec-patchers.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7298       +/-   ##
===========================================
- Coverage   58.41%   28.96%   -29.45%     
===========================================
  Files         838      646      -192     
  Lines       36607    14499    -22108     
  Branches     3937     2543     -1394     
===========================================
- Hits        21383     4200    -17183     
+ Misses      14930    10053     -4877     
+ Partials      294      246       -48     
Flag Coverage Δ
server-test ?
unittest 28.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akumatus
Copy link
Member Author

@pengx17 I am not sure how to fix this lint problem, could you have a look at it?

截屏2024-06-21 14 43 07

Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will fix the type issue

@graphite-app graphite-app bot merged commit f85a321 into canary Jun 21, 2024
32 checks passed
Copy link

graphite-app bot commented Jun 21, 2024

Merge activity

@graphite-app graphite-app bot deleted the feat/bump-bs-0621 branch June 21, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:component mod:dev mod:env mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants