Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): peek view api enhancements #7288

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jun 20, 2024

Copy link

graphite-app bot commented Jun 20, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Jun 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review June 20, 2024 09:56
Copy link

nx-cloud bot commented Jun 20, 2024

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 10.63830% with 42 lines in your changes missing coverage. Please review.

Project coverage is 58.42%. Comparing base (f85a321) to head (e085b92).

Files Patch % Lines
.../core/src/modules/peek-view/view/doc-peek-view.tsx 0.00% 13 Missing ⚠️
...d/core/src/modules/peek-view/entities/peek-view.ts 0.00% 7 Missing ⚠️
...e/src/modules/peek-view/view/peek-view-manager.tsx 0.00% 7 Missing ⚠️
.../frontend/component/src/lit-react/to-react-node.ts 33.33% 6 Missing ⚠️
.../src/modules/peek-view/view/peek-view-controls.tsx 14.28% 6 Missing ⚠️
.../block-suite-editor/specs/custom/spec-patchers.tsx 33.33% 2 Missing ⚠️
...ore/src/components/affine/reference-link/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7288      +/-   ##
==========================================
+ Coverage   58.41%   58.42%   +0.01%     
==========================================
  Files         838      839       +1     
  Lines       36608    36592      -16     
  Branches     3937     3936       -1     
==========================================
- Hits        21383    21379       -4     
+ Misses      14931    14919      -12     
  Partials      294      294              
Flag Coverage Δ
server-test 77.71% <ø> (ø)
unittest 28.97% <10.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@graphite-app graphite-app bot requested review from forehalo and EYHN June 20, 2024 11:03
@pengx17 pengx17 force-pushed the 06-20-feat_core_peek_view_api_enhancements branch from a7d58cb to f854abb Compare June 21, 2024 07:00
@pengx17 pengx17 changed the base branch from canary to feat/bump-bs-0621 June 21, 2024 07:00
@akumatus akumatus mentioned this pull request Jun 21, 2024
@pengx17 pengx17 changed the base branch from feat/bump-bs-0621 to canary June 21, 2024 07:09
Copy link
Collaborator Author

pengx17 commented Jun 21, 2024

Merge activity

  • Jun 21, 3:09 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Jun 21, 3:14 AM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Jun 21, 3:20 AM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Jun 21, 3:53 AM EDT: pengx17 merged this pull request with the Graphite merge queue.

@pengx17 pengx17 force-pushed the 06-20-feat_core_peek_view_api_enhancements branch from f854abb to c2377cb Compare June 21, 2024 07:26
@pengx17 pengx17 force-pushed the 06-20-feat_core_peek_view_api_enhancements branch from c2377cb to e085b92 Compare June 21, 2024 07:38
@graphite-app graphite-app bot merged commit e085b92 into canary Jun 21, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 06-20-feat_core_peek_view_api_enhancements branch June 21, 2024 07:53
Copy link

sentry-io bot commented Jun 21, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'closest') / View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants