Move cursor to end of line when cursor is in last line and ArrowDown is pressed

[SevenOutman]

As the source code shows, this behavior is deliberately prevented. Most editors we're using everyday (whether to code or to write articles) have this behavior and I believe we're used to it. Could your give me a good reason for preventing it?

[doodlewind]

Hi, I think this is a great question about how BlockSuite works!

Based on the multiple-contenteditable design in BlockSuite, thought each text block supports multiple wrapped lines, it has a standalone boundary by default. So when you are pressing ArrowDown at the red line position:

The default behavior is to move the cursor to A, which this is not expected. Instead, we wrote a bit code to locate the cursor to B based on the cursor position, making the behavior intuitive.

[SevenOutman]

Moving to next block makes sense. But what if cursor is at the last line of the last block?

In AFFiNE online demo, when cursor is at the last line of the last block, pressing ArrowDown will create a new empty block at the end. But after I deleted this empty block, it wouldn't create a new block when I press ArrowDown again (as shown in the screencast below). And that's when I believe it's reasonable to move cursor to the end of the line.

AFFiNE.arrowdown.when.cursor.at.last.line.mov

[doodlewind]

Thanks for your feedback! I think we didn't (and won't FTM) create a new empty block automatically at the end on pressing ArrowDown. Instead, there is an empty paragraph block added by default (see https://github.com/toeverything/blocksuite/blob/master/packages/store/src/workspace/workspace.ts#L258-L270 ). Maybe you just located to that empty paragraph block.

I think you can convert (or reference) this to issue, and PR welcome if you want to move cursor to the end of the line when you press ArrowDown at the end of the last block!

[SevenOutman]

Sure, I've created an issue #2417 from this discussion and a PR #2418 with the fix.