Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(edgeless): split toolbar modules #1348

Merged
merged 14 commits into from
Feb 25, 2023
Merged

refactor(edgeless): split toolbar modules #1348

merged 14 commits into from
Feb 25, 2023

Conversation

alt1o
Copy link
Contributor

@alt1o alt1o commented Feb 23, 2023

2023-02-23.23.04.35.mov

@codesandbox
Copy link

codesandbox bot commented Feb 23, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Feb 23, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 25, 2023 at 4:02AM (UTC)
blocksuite-react ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 25, 2023 at 4:02AM (UTC)

@doodlewind doodlewind self-assigned this Feb 24, 2023
@doodlewind
Copy link
Member

TODOs:

  • Try remove the edgeless-toolbar-with-flag wrapper and attach edgeless-toolbar without imperative document.createElement

@alt1o alt1o force-pushed the feat/edgeless-toolbar-integrate branch from 73782c0 to bdc2b23 Compare February 24, 2023 12:10
himself65
himself65 reviewed Feb 24, 2023
View reviewed changes
Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know what you are doing, but the first left icon is quare

doodlewind
doodlewind approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers!

@doodlewind doodlewind changed the title feat(edgeless): toolbar integrate refactor(edgeless): split toolbar modules Feb 25, 2023
@doodlewind doodlewind merged commit 1eefbe6 into toeverything:master Feb 25, 2023
@doodlewind doodlewind mentioned this pull request Feb 27, 2023
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 left review comments

@doodlewind doodlewind doodlewind approved these changes

Assignees

@doodlewind doodlewind

@alt1o alt1o

Labels
None yet
Projects
AFFiNE Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alt1o @doodlewind @himself65