refactor: simplify test #1379

lawvs · 2023-02-26T07:57:24Z

Use

  const rects = page.locator('.affine-page-selected-rects-container > *');
  await expect(rects).toHaveCount(1);

codesandbox · 2023-02-26T07:57:26Z

vercel · 2023-02-26T07:57:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
blocksuite	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 26, 2023 at 9:42AM (UTC)
blocksuite-react	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 26, 2023 at 9:42AM (UTC)

fundon

Nice!

lawvs added 2 commits February 26, 2023 15:56

chore: update tests

bf971d1

fix: typo

725af00

lawvs requested a review from fundon February 26, 2023 07:57

github-actions bot assigned lawvs Feb 26, 2023

vercel bot deployed to Preview – blocksuite February 26, 2023 07:57 View deployment

vercel bot deployed to Preview – blocksuite-react February 26, 2023 07:58 View deployment

lawvs changed the title ~~Refactor: simpify test~~ refactor: simplify test Feb 26, 2023

fix: test snapshot

2953918

vercel bot deployed to Preview – blocksuite February 26, 2023 08:05 View deployment

vercel bot deployed to Preview – blocksuite-react February 26, 2023 08:06 View deployment

fix: select nothing should not throw error

bc5e4f1

vercel bot deployed to Preview – blocksuite-react February 26, 2023 08:14 View deployment

vercel bot deployed to Preview – blocksuite February 26, 2023 08:15 View deployment

fundon approved these changes Feb 26, 2023

View reviewed changes

fix: skip test

c727473

vercel bot deployed to Preview – blocksuite February 26, 2023 09:42 View deployment

vercel bot deployed to Preview – blocksuite-react February 26, 2023 09:42 View deployment

lawvs merged commit 4fc7e4c into master Feb 26, 2023

lawvs deleted the Refactor/test branch February 26, 2023 09:49

Provide feedback