Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add selection.state.draggingArea #1512

Merged
merged 7 commits into from
Mar 6, 2023
Merged

refactor: add selection.state.draggingArea #1512

merged 7 commits into from
Mar 6, 2023

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 6, 2023

part of #1480

@codesandbox
Copy link

codesandbox bot commented Mar 6, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Mar 6, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 7:36AM (UTC)
blocksuite-react ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 7:36AM (UTC)

@fundon
Copy link
Contributor Author

fundon commented Mar 6, 2023

It would be better to unify Point Rect.

e.g. IPoint, IBound, too many types.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023 •
edited

Size Change: 0 B

Total Size: 298 kB

ℹ️ View Unchanged
Filename Size
packages/blocks/dist/__internal__/index.js 81 B
packages/blocks/dist/__internal__/rich-text/bracket-complete.js 823 B
packages/blocks/dist/__internal__/rich-text/keyboard.js 2.62 kB
packages/blocks/dist/__internal__/rich-text/link-node/create-link.js 901 B
packages/blocks/dist/__internal__/rich-text/link-node/index.js 125 B
packages/blocks/dist/__internal__/rich-text/link-node/link-node.js 1.71 kB
packages/blocks/dist/__internal__/rich-text/link-node/mock-select-node.js 607 B
packages/blocks/dist/__internal__/rich-text/markdown-convert.js 1.73 kB
packages/blocks/dist/__internal__/rich-text/quill-keyboard.js 2.02 kB
packages/blocks/dist/__internal__/rich-text/rich-text-operations.js 2.99 kB
packages/blocks/dist/__internal__/rich-text/rich-text.js 2.43 kB
packages/blocks/dist/__internal__/service.js 520 B
packages/blocks/dist/__internal__/service/index.js 657 B
packages/blocks/dist/__internal__/utils/block-range.js 1.45 kB
packages/blocks/dist/__internal__/utils/check-line.js 2.4 kB
packages/blocks/dist/__internal__/utils/common-operations.js 850 B
packages/blocks/dist/__internal__/utils/components.js 1.04 kB
packages/blocks/dist/__internal__/utils/filesys.js 627 B
packages/blocks/dist/__internal__/utils/gesture.js 1.49 kB
packages/blocks/dist/__internal__/utils/hotkey.js 1.29 kB
packages/blocks/dist/__internal__/utils/index.js 291 B
packages/blocks/dist/__internal__/utils/lit.js 509 B
packages/blocks/dist/__internal__/utils/query.js 3.46 kB
packages/blocks/dist/__internal__/utils/rect.js 963 B
packages/blocks/dist/__internal__/utils/selection.js 6.58 kB
packages/blocks/dist/__internal__/utils/std.js 1 kB
packages/blocks/dist/__internal__/utils/types.js 64 B
packages/blocks/dist/code-block/code-block.js 2.13 kB
packages/blocks/dist/code-block/code-model.js 238 B
packages/blocks/dist/code-block/code-service.js 473 B
packages/blocks/dist/code-block/components/index.js 84 B
packages/blocks/dist/code-block/components/lang-list.js 1.84 kB
packages/blocks/dist/code-block/components/syntax-code-block.js 2.18 kB
packages/blocks/dist/code-block/index.js 105 B
packages/blocks/dist/code-block/utils/code-languages.js 1.15 kB
packages/blocks/dist/components/block-hub.js 5.02 kB
packages/blocks/dist/components/button.js 1.3 kB
packages/blocks/dist/components/drag-handle.js 3.77 kB
packages/blocks/dist/components/format-quick-bar/button.js 780 B
packages/blocks/dist/components/format-quick-bar/format-bar-node.js 2.82 kB
packages/blocks/dist/components/format-quick-bar/index.js 1.53 kB
packages/blocks/dist/components/format-quick-bar/styles.js 523 B
packages/blocks/dist/components/index.js 129 B
packages/blocks/dist/components/link-popover/create-link-popover.js 1.22 kB
packages/blocks/dist/components/link-popover/index.js 145 B
packages/blocks/dist/components/link-popover/link-popover.js 3.14 kB
packages/blocks/dist/components/link-popover/styles.js 1.07 kB
packages/blocks/dist/components/loader.js 1.03 kB
packages/blocks/dist/components/remote-selection/remote-selection.js 2.38 kB
packages/blocks/dist/components/slash-menu/config.js 2.04 kB
packages/blocks/dist/components/slash-menu/index.js 1.34 kB
packages/blocks/dist/components/slash-menu/slash-menu-node.js 3.38 kB
packages/blocks/dist/components/slash-menu/styles.js 791 B
packages/blocks/dist/components/toast.js 1.22 kB
packages/blocks/dist/components/tooltip/index.js 82 B
packages/blocks/dist/components/tooltip/tooltip.js 804 B
packages/blocks/dist/counter-block/counter-block.js 691 B
packages/blocks/dist/counter-block/index.js 88 B
packages/blocks/dist/database-block/components/add-column-type-popup.js 1.34 kB
packages/blocks/dist/database-block/components/cell-container.js 1.44 kB
packages/blocks/dist/database-block/components/column-type/index.js 195 B
packages/blocks/dist/database-block/components/column-type/number.js 958 B
packages/blocks/dist/database-block/components/column-type/rich-text.js 1.72 kB
packages/blocks/dist/database-block/components/column-type/select.js 1.27 kB
packages/blocks/dist/database-block/components/create-database-modal.js 762 B
packages/blocks/dist/database-block/components/edit-column-popup.js 803 B
packages/blocks/dist/database-block/database-block.js 3.01 kB
packages/blocks/dist/database-block/database-model.js 330 B
packages/blocks/dist/database-block/index.js 111 B
packages/blocks/dist/database-block/register.js 741 B
packages/blocks/dist/database-block/utils.js 408 B
packages/blocks/dist/divider-block/divider-block.js 837 B
packages/blocks/dist/divider-block/divider-model.js 209 B
packages/blocks/dist/divider-block/divider-service.js 217 B
packages/blocks/dist/divider-block/index.js 98 B
packages/blocks/dist/embed-block/embed-block.js 1.4 kB
packages/blocks/dist/embed-block/embed-model.js 248 B
packages/blocks/dist/embed-block/image/image-block.js 2.4 kB
packages/blocks/dist/embed-block/image/index.js 86 B
packages/blocks/dist/embed-block/image/placeholder/circle-loading.js 830 B
packages/blocks/dist/embed-block/image/placeholder/image-not-found.js 1.66 kB
packages/blocks/dist/embed-block/image/placeholder/loading-card.js 875 B
packages/blocks/dist/embed-block/index.js 104 B
packages/blocks/dist/frame-block/frame-block.js 778 B
packages/blocks/dist/frame-block/frame-model.js 233 B
packages/blocks/dist/frame-block/index.js 96 B
packages/blocks/dist/index.js 718 B
packages/blocks/dist/list-block/index.js 95 B
packages/blocks/dist/list-block/list-block.js 1.63 kB
packages/blocks/dist/list-block/list-model.js 243 B
packages/blocks/dist/list-block/list-service.js 490 B
packages/blocks/dist/list-block/utils/get-list-icon.js 478 B
packages/blocks/dist/list-block/utils/get-list-info.js 419 B
packages/blocks/dist/list-block/utils/get-number-prefix.js 529 B
packages/blocks/dist/list-block/utils/icons.js 1.38 kB
packages/blocks/dist/models.js 431 B
packages/blocks/dist/page-block/default/components.js 1.36 kB
packages/blocks/dist/page-block/default/default-page-block.js 4.2 kB
packages/blocks/dist/page-block/default/selection-manager/block-drag-handlers.js 904 B
packages/blocks/dist/page-block/default/selection-manager/default-selection-manager.js 4 kB
packages/blocks/dist/page-block/default/selection-manager/embed-resize-manager.js 808 B
packages/blocks/dist/page-block/default/selection-manager/index.js 135 B
packages/blocks/dist/page-block/default/selection-manager/native-drag-handlers.js 290 B
packages/blocks/dist/page-block/default/selection-manager/selection-state.js 1.01 kB
packages/blocks/dist/page-block/default/selection-manager/utils.js 2.32 kB
packages/blocks/dist/page-block/default/utils.js 4.44 kB
packages/blocks/dist/page-block/edgeless/components.js 3.52 kB
packages/blocks/dist/page-block/edgeless/edgeless-page-block.js 3.26 kB
packages/blocks/dist/page-block/edgeless/mode-controllers/brush-mode.js 913 B
packages/blocks/dist/page-block/edgeless/mode-controllers/default-mode.js 2.09 kB
packages/blocks/dist/page-block/edgeless/mode-controllers/index.js 354 B
packages/blocks/dist/page-block/edgeless/mode-controllers/pan-mode.js 494 B
packages/blocks/dist/page-block/edgeless/mode-controllers/shape-mode.js 836 B
packages/blocks/dist/page-block/edgeless/selection-manager.js 1.47 kB
packages/blocks/dist/page-block/edgeless/toolbar/brush-tool/brush-menu.js 1.5 kB
packages/blocks/dist/page-block/edgeless/toolbar/brush-tool/brush-tool-button.js 1.14 kB
packages/blocks/dist/page-block/edgeless/toolbar/brush-tool/color-panel.js 1.21 kB
packages/blocks/dist/page-block/edgeless/toolbar/edgeless-toolbar.js 1.18 kB
packages/blocks/dist/page-block/edgeless/toolbar/shape-tool/shape-menu-config.js 295 B
packages/blocks/dist/page-block/edgeless/toolbar/shape-tool/shape-menu.js 949 B
packages/blocks/dist/page-block/edgeless/toolbar/shape-tool/shape-tool-button.js 1.06 kB
packages/blocks/dist/page-block/edgeless/toolbar/tool-icon-button.js 1.08 kB
packages/blocks/dist/page-block/edgeless/utils.js 1.03 kB
packages/blocks/dist/page-block/edgeless/view-control-bar.js 1.42 kB
packages/blocks/dist/page-block/index.js 212 B
packages/blocks/dist/page-block/page-model.js 223 B
packages/blocks/dist/page-block/page-service.js 286 B
packages/blocks/dist/page-block/utils/bind-hotkey.js 2.92 kB
packages/blocks/dist/page-block/utils/const.js 682 B
packages/blocks/dist/page-block/utils/container-operations.js 3.03 kB
packages/blocks/dist/page-block/utils/index.js 138 B
packages/blocks/dist/page-block/utils/position.js 2.3 kB
packages/blocks/dist/paragraph-block/index.js 100 B
packages/blocks/dist/paragraph-block/paragraph-block.js 1.49 kB
packages/blocks/dist/paragraph-block/paragraph-model.js 235 B
packages/blocks/dist/paragraph-block/paragraph-service.js 343 B
packages/blocks/dist/std.js 153 B
packages/blocks/dist/surface-block/index.js 88 B
packages/blocks/dist/surface-block/surface-model.js 208 B
packages/editor/dist/components/editor-container.js 1.88 kB
packages/editor/dist/components/index.js 119 B
packages/editor/dist/components/simple-affine-editor.js 1.11 kB
packages/editor/dist/index.js 443 B
packages/editor/dist/managers/clipboard/content-parser/index.js 1.66 kB
packages/editor/dist/managers/clipboard/content-parser/parse-html.js 3.37 kB
packages/editor/dist/managers/clipboard/content-parser/parse-text.js 148 B
packages/editor/dist/managers/clipboard/copy-cut-manager.js 2.18 kB
packages/editor/dist/managers/clipboard/event-dispatcher.js 708 B
packages/editor/dist/managers/clipboard/index.js 494 B
packages/editor/dist/managers/clipboard/item.js 174 B
packages/editor/dist/managers/clipboard/markdown-utils.js 1.23 kB
packages/editor/dist/managers/clipboard/paste-manager.js 3.17 kB
packages/editor/dist/managers/clipboard/types.js 324 B
packages/editor/dist/managers/clipboard/utils.js 864 B
packages/editor/dist/managers/file-exporter/exporter-style.js 668 B
packages/editor/dist/managers/file-exporter/file-exporter.js 1.97 kB
packages/editor/dist/managers/index.js 85 B
packages/editor/dist/utils/editor.js 843 B
packages/editor/dist/utils/index.js 81 B
packages/global/dist/config/consts.js 434 B
packages/global/dist/config/consts/affine-style-consts.js 713 B
packages/global/dist/config/consts/block-hub.js 936 B
packages/global/dist/config/icons.js 28.4 kB
packages/global/dist/config/index.js 88 B
packages/global/dist/database.js 67 B
packages/global/dist/debug.js 1 kB
packages/global/dist/error.js 288 B
packages/global/dist/types.js 64 B
packages/global/dist/utils.js 1.01 kB
packages/global/dist/utils/disposable.js 467 B
packages/global/dist/utils/slot.js 941 B
packages/global/dist/utils/web.js 813 B
packages/phasor/dist/consts.js 100 B
packages/phasor/dist/elements/base-element.js 433 B
packages/phasor/dist/elements/brush/brush-element.js 1.01 kB
packages/phasor/dist/elements/brush/brush-element.unit.spec.js 569 B
packages/phasor/dist/elements/debug/debug-element.js 454 B
packages/phasor/dist/elements/index.js 209 B
packages/phasor/dist/elements/shape/shape-element.js 587 B
packages/phasor/dist/elements/shape/shape-element.unit.spec.js 647 B
packages/phasor/dist/elements/shape/shapes/diamond.js 511 B
packages/phasor/dist/elements/shape/shapes/ellipse.js 470 B
packages/phasor/dist/elements/shape/shapes/index.js 190 B
packages/phasor/dist/elements/shape/shapes/rect.js 628 B
packages/phasor/dist/elements/shape/shapes/triangle.js 496 B
packages/phasor/dist/elements/shape/types.js 64 B
packages/phasor/dist/grid.js 855 B
packages/phasor/dist/index.js 177 B
packages/phasor/dist/renderer.js 1.44 kB
packages/phasor/dist/surface.js 1.94 kB
packages/phasor/dist/utils/bound.js 377 B
packages/phasor/dist/utils/bound.unit.spec.js 355 B
packages/phasor/dist/utils/debug-utils.js 476 B
packages/phasor/dist/utils/hit-utils.js 183 B
packages/phasor/dist/utils/tl-utils.js 9.8 kB
packages/phasor/dist/utils/vec.js 2.8 kB
packages/phasor/dist/utils/xywh.js 196 B
packages/react/dist/components/Editor/index.js 699 B
packages/react/dist/editor.js 115 B
packages/react/dist/index.js 81 B
packages/react/dist/store/currentWorkspace/index.js 746 B
packages/react/dist/store/index.js 950 B
packages/react/dist/store/manager/index.js 601 B
packages/react/dist/types/index.js 64 B
packages/store/dist/__tests__/test-utils-dom.js 1.03 kB
packages/store/dist/__tests__/test-utils-node.js 317 B
packages/store/dist/awareness.js 1.8 kB
packages/store/dist/base.js 615 B
packages/store/dist/index.js 505 B
packages/store/dist/persistence/blob/cloud-sync-manager.js 1.2 kB
packages/store/dist/persistence/blob/duplex-provider.js 1.08 kB
packages/store/dist/persistence/blob/index.js 425 B
packages/store/dist/persistence/blob/storage.js 433 B
packages/store/dist/persistence/blob/types.js 182 B
packages/store/dist/persistence/blob/utils.js 412 B
packages/store/dist/persistence/doc/debug-provider.js 812 B
packages/store/dist/persistence/doc/idb-provider.js 1.33 kB
packages/store/dist/persistence/doc/index.js 118 B
packages/store/dist/space.js 317 B
packages/store/dist/store.js 1.36 kB
packages/store/dist/text-adapter.js 2.93 kB
packages/store/dist/utils/id-generator.js 253 B
packages/store/dist/utils/jsx.js 1.26 kB
packages/store/dist/utils/utils.js 1.1 kB
packages/store/dist/workspace/__tests__/test-app.js 920 B
packages/store/dist/workspace/__tests__/test-entry.js 508 B
packages/store/dist/workspace/__tests__/workspace.spec.js 291 B
packages/store/dist/workspace/index.js 102 B
packages/store/dist/workspace/migrations.js 904 B
packages/store/dist/workspace/page.js 6.46 kB
packages/store/dist/workspace/search.js 1.5 kB
packages/store/dist/workspace/workspace.js 2.7 kB
packages/store/dist/yjs/index.js 522 B
packages/store/dist/yjs/proxy.js 682 B
packages/virgo/dist/components/index.js 102 B
packages/virgo/dist/components/virgo-element.js 785 B
packages/virgo/dist/components/virgo-line.js 645 B
packages/virgo/dist/components/virgo-text.js 730 B
packages/virgo/dist/constant.js 95 B
packages/virgo/dist/index.js 149 B
packages/virgo/dist/tests/convert.unit.spec.js 373 B
packages/virgo/dist/tests/editor.unit.spec.js 552 B
packages/virgo/dist/tests/utils/misc.js 649 B
packages/virgo/dist/tests/virgo.spec.js 1.6 kB
packages/virgo/dist/types.js 64 B
packages/virgo/dist/utils/attributes-renderer.js 603 B
packages/virgo/dist/utils/base-attributes.js 175 B
packages/virgo/dist/utils/convert.js 524 B
packages/virgo/dist/utils/index.js 118 B
packages/virgo/dist/utils/render.js 226 B
packages/virgo/dist/virgo.js 5.38 kB

compressed-size-action

@doodlewind doodlewind self-assigned this Mar 6, 2023
himself65
himself65 reviewed Mar 6, 2023
View reviewed changes
packages/blocks/src/__internal__/utils/rect.ts
@@ -1,3 +1,5 @@
import { clamp } from '../index.js';

export class Point {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need unit test for the basic class

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use vitest with happy-dom

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class implementation looks trivial, we have added tests in tl-utils in phasor. So I suggest not to do that in this PR.

@doodlewind doodlewind changed the title refactor: add dragging-area refactor: add selection.state.draggingArea Mar 6, 2023
@doodlewind doodlewind merged commit b2587e1 into toeverything:master Mar 6, 2023
@fundon fundon deleted the refactor/add-dragging-area branch March 6, 2023 07:36
@doodlewind doodlewind mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 left review comments

@doodlewind doodlewind doodlewind approved these changes

@Flrande Flrande Awaiting requested review from Flrande

@JimmFly JimmFly Awaiting requested review from JimmFly

Assignees

@fundon fundon

@doodlewind doodlewind

Labels
None yet
Projects
AFFiNE Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fundon @doodlewind @himself65