Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move codeBlockOption to code block #1519

Merged
merged 10 commits into from
Mar 6, 2023

Conversation

lawvs
Copy link
Member

@lawvs lawvs commented Mar 6, 2023

Fix #1513
Part of #1480

CodeOption should be maintained by the code block itself

@codesandbox
Copy link

codesandbox bot commented Mar 6, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Mar 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 10:27AM (UTC)
blocksuite-react ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 10:27AM (UTC)

@lawvs lawvs merged commit 63991f8 into master Mar 6, 2023
@lawvs lawvs deleted the refactor/extract-code-option branch March 6, 2023 10:34
fundon added a commit to fundon/blocksuite that referenced this pull request Mar 6, 2023
…find-block

* master:
  style: update tooltip naming (toeverything#1525)
  fix: tooltip not appeat due to overflow (toeverything#1522)
  refactor: move `codeBlockOption` to code block (toeverything#1519)
  refactor: extract block hub templates (toeverything#1521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

codeblock in readonly mode
2 participants