Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(selection): switch to document.elementsFromPoint #1530

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 6, 2023

part of #1480

  1. Change to focusedBlock
  2. Change to clickedBlock
    private _cursor: number | null = 0;
    private _lastSelectedIndex = -1;
  3. benchmarks?
    Scroll to the end of container then try to drag block
  4. fix tests

Fixes

  • must clear subtrees when dropping blocks
  • dragend position in chrome
  • drag-handle line position

Example

https://blocksuite-git-fork-fundon-refactor-use-doc-9a7f2e-toeverything.vercel.app/?init=AACkAcHktOoZBu%2FaksgFAIHktOoZr9qSyAXB5LTqGWzCrt%2BzGAXB5LTqGQDCrt%2BzGACB5LTqGcKu37MYAoHktOoZwq7fsxgCgeS06hnCrt%2BzGAKB5LTqGcKu37MYAoHktOoZwq7fsxgCgeS06hnCrt%2BzGAKB5LTqGcKu37MYAoHktOoZwq7fsxgCgeS06hnCrt%2BzGAiB5LTqGcKu37MYgQHv2pLIBbICkgQEAQMGij1CxD2AQOY%2FVBoYRB7KAZYBBAJWcCA6AQMGZjJYEEwgAQMGThpgGEwgAQMGThpgGEwgAQMGThpgGEwgAQMGThpgGEwgAQMGThpgGEwgAQMGThpgGEwgAQMGThpgJEsA1gUBA7AFQt4FSqQF1AUABki4BOoEAAZIjgTABAAGSKQD1gMABki6AuwCAAZIkALCAgAGSKYB2AEABkg8bgAGSAQKBBABAlAaoAPWAwECSA5uOF4yWkwwAQJIDlAacDRKTCABAkgOUBpgJEpMIAECSA5QGmAkSkwgAQJIDlAaYCRKTCABAkgOUBpgJEpMIAECSA5QGmAkSkwgAQJIDlAaYCRKTCABAkgOUBpgJEpMIAECSA5QGmAkSkz6BgIBAAgBBhQBAwyCAQEACAEBzAGEAa4xAgEI4DGMMgEDVB4KAQMG6DKUMhhOIgEDBk5GGEwgAQMGTkYYTCABAwZORhhMIAEDBk5GGEwgAQMGTkYYTCABAwZORhhMIAEDBk5GGEwgAQMGTkYYTCABA0gYSlIWTB4GAQNMHErSAZYBTiYBA0oaStIClgJMJAEDShpK0gOWA0wkAQNKGkrSBJYETCAGAQNMHErUBZgFTiYBA0oaStQGmAZMJAEDShpK1AeYB0wkAQNKGkrUCJgITDQBAgpCWigBAgpCShoBAgpCShwBAgpCSh4BAgpCSiABAgpCSgO8AQC9CgAAJwAoASEAKAAnACgAAAChAQAAoQAAAAEAoQAhAAAAoQAAAKEAAAChACEAAAChAAAAoQAAAKEAAACnAAgAgQCIAKEAhAChACcAKAEhACgAJwAoAAAAoQCnAAgAoQAAAAQAoQAnACgBIQAoACcAKAAAAKEApwAIAKEAAAAEAKEAJwAoASEAKAAnACgAAAChAKcACAChAAAABAChACcAKAEhACgAJwAoAAAAoQCnAAgAoQAAAAQAoQAnACgBIQAoACcAKAAAAKEApwAIAKEAAAAEAKEAJwAoASEAKAAnACgAAAChAKcACAChAAAABAChACcAKAEhACgAJwAoAAAAoQCnAAgAoQAAAAQAoQAnACgBIQAoACcAKAAAAKcBCACnAAgABACoACcAKAEnACgAJwAoAIgApwAIAKcBCACnAAgApwEIAKcACACnAQgApwAIAKcBCACnAAgApwEIAKcACACnAQgApwAIAKcBCACnAAgApwEIAKcACACnAQgAiAAnACgBJwAoACcAyAAEAKgAJwAoAScAKAAnAMgApwEIAKcACAAEAKgAJwAoAScAKAAnAIgApwEIAKcACAAEAKgAJwAoAScAKAAnAIgApwEIAKcACAAEAKgAJwAoAScAKAAnAIgApwEIAKcACAAEAKgAJwAoAScAKAAnAIgApwEIAKcACAAEAKgAJwAoAScAKAAnAIgApwEIAKcACAAEAKgAJwAoAScAKAAnAIgApwEIAKcACAAEAKgAJwAoAScAKAAnAIgApwEIAKcACAAEAKgAJwAoAScAKAAnAIgApwEIAKcACAAEAKgAJwAoAScAKAAnAIgApwEIAKcACAAEAKgAJwAHACgCJwAoCCcAKAEnAwQAJwAoAScBKAEhAQgAIQAAACEAAAAhAAAAIQAAACEAAAAhAAAAIQAAACEAAAAhAAAAIQAAACEAAAAnASgKoQAhAAAAJwAoASEAKAAnACgAAAChAAQAJwAoASEAKAAnACgAAAChAQAAoQAAAAQAoQAnACgBIQAoACcAKAAAAKEBAAChAAAABAChACcAKAEhACgAJwAoAAAAoQEAAKEAAAAEAKEAJwAoASEAKAAnACgAAAChAQAAoQAAAAQAoQAnACgBIQAoACcAKAAAAKEBAAChAAAABAChACcAKAEhACgAJwAoAAAAoQEAAKEAAAAEAKEAJwAoASEAKAAnACgAAAChAQAAoQAAAAQAoQAnACgBIQAoACcAKAAAAKEBAAChAAAABAChACcAKAEhACgAJwAoAAAApwChAAAAoQAAAAQAoQAnACgBIQAoACcAKAAAAKcACACnAKEAAAABAKEAhAAnACgBIQAoACcAKAAAAKcACACnAKEAAAAEAKEAJwAoASEAKAAnACgAAACnAAgApwChAAAABAChACcAKAEhACgAJwAoAAAApwAIAKcAoQAAAAQAoQAnACgBIQAoACcAKAAAAKcACACnAKEAAAABAKEAhAAnACgBIQAoACcAKAAAAKcACACnAKEAAAAEAKEAJwAoASEAKAAnACgAAACnAAgApwChAAAABAChACcAKAEhACgAJwAoAAAApwAIAKcAoQAAAAQAoQAnACgBIQAoACcAKAAAAKcACAChAQAABAChACEAAAAnACgBJwAhACcAAAABAKgAoQAnACgBJwAhACcAAAABAKgAoQAnACgBJwAhACcAAAABAKgAoQAnACgBJwAhACcAAAABAKgAoQAnACgBJwAhACcAAAABAKgAoQAnACgBJwAhACcAAAABAKgAoZ8m1yJzcGFjZTpwYWdlMDM0NjcwMjQ2NDE6MHN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0cHJvcDpjaGVja2Vkc3BhY2U6cGFnZTAzNDY3MDI0NjQxOjFzcGFjZTpwYWdlMDM0NjcwMjQ2NDE6MjJzcGFjZTpwYWdlMDM0NjcwMjQ2NDE6M3N5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0cHJvcDpjaGVja2VkM3NwYWNlOnBhZ2UwMzQ2NzAyNDY0MTo0c3lzOmlkc3lzOmZsYXZvdXJzeXM6Y2hpbGRyZW5wcm9wOnR5cGVwcm9wOnRleHRwcm9wOmNoZWNrZWQ0c3BhY2U6cGFnZTAzNDY3MDI0NjQxOjVzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnByb3A6dHlwZXByb3A6dGV4dHByb3A6Y2hlY2tlZDVzcGFjZTpwYWdlMDM0NjcwMjQ2NDE6NnN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0cHJvcDpjaGVja2VkNnNwYWNlOnBhZ2UwMzQ2NzAyNDY0MTo3c3lzOmlkc3lzOmZsYXZvdXJzeXM6Y2hpbGRyZW5wcm9wOnR5cGVwcm9wOnRleHRwcm9wOmNoZWNrZWQ3c3BhY2U6cGFnZTAzNDY3MDI0NjQxOjhzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnByb3A6dHlwZXByb3A6dGV4dHByb3A6Y2hlY2tlZDhzcGFjZTpwYWdlMDM0NjcwMjQ2NDE6OXN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0cHJvcDpjaGVja2VkOXNwYWNlOnBhZ2UwMzQ2NzAyNDY0MToxMHN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0cHJvcDpjaGVja2VkMHNwYWNlOnBhZ2UwMzI3NTQ4NDAzNDowc3lzOmlkc3lzOmZsYXZvdXJzeXM6Y2hpbGRyZW5wcm9wOnR5cGVwcm9wOnRleHRwcm9wOmNoZWNrZWRzcGFjZTpwYWdlMDMyNzU0ODQwMzQ6MXN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0UDBzcGFjZTpwYWdlMDMyNzU0ODQwMzQ6MnN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0UDFzcGFjZTpwYWdlMDMyNzU0ODQwMzQ6M3N5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0UDJzcGFjZTpwYWdlMDMyNzU0ODQwMzQ6NHN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0UDNzcGFjZTpwYWdlMDMyNzU0ODQwMzQ6NXN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0UDRzcGFjZTpwYWdlMDMyNzU0ODQwMzQ6NnN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0UDVzcGFjZTpwYWdlMDMyNzU0ODQwMzQ6N3N5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0UDZzcGFjZTpwYWdlMDMyNzU0ODQwMzQ6OHN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0UDdzcGFjZTpwYWdlMDMyNzU0ODQwMzQ6OXN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0UDhzcGFjZTpwYWdlMDMyNzU0ODQwMzQ6MTBzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnByb3A6dHlwZXByb3A6dGV4dFA5c3BhY2U6cGFnZTAzMjc1NDg0MDM0OjExc3lzOmlkc3lzOmZsYXZvdXJzeXM6Y2hpbGRyZW5wcm9wOnR5cGVwcm9wOnRleHRQMHNwYWNlOm1ldGFwYWdlc2lkdGl0bGVjcmVhdGVEYXRlc3BhY2U6bWV0YXZlcnNpb25zYWZmaW5lOmNvZGVhZmZpbmU6cGFyYWdyYXBoYWZmaW5lOnBhZ2VhZmZpbmU6bGlzdGFmZmluZTpmcmFtZWFmZmluZTpkaXZpZGVyYWZmaW5lOmVtYmVkYWZmaW5lOnN1cmZhY2VhZmZpbmU6ZGF0YWJhc2VzcGFjZTpwYWdlMDc0NjczOTM3NTowc3lzOmlkc3lzOmZsYXZvdXJtZXRhOnRhZ3NtZXRhOnRhZ1NjaGVtYXN5czpjaGlsZHJlbnByb3A6dGl0bGVXZWxjb21lIHRvIEJsb2NrU3VpdGUgcGxheWdyb3VuZHNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjFzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjJzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnByb3A6eHl3aHNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjNzcGFjZTpwYWdlMDc0NjczOTM3NTo0c3BhY2U6cGFnZTA3NDY3MzkzNzU6NXNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjZzcGFjZTpwYWdlMDc0NjczOTM3NTo3c3BhY2U6cGFnZTA3NDY3MzkzNzU6OHNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjlzcGFjZTpwYWdlMDc0NjczOTM3NToxMHNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjExc3BhY2U6cGFnZTA3NDY3MzkzNzU6MTJzcGFjZTpwYWdlMDc0NjczOTM3NToxM2VsZW1lbnRzMGlkaW5kZXh0eXBleHl3aHNoYXBlVHlwZXJhZGl1c2ZpbGxlZGZpbGxDb2xvcnN0cm9rZVdpZHRoc3Ryb2tlQ29sb3JzdHJva2VTdHlsZXNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjE0c3BhY2U6cGFnZTA3NDY3MzkzNzU6MTVzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnByb3A6dHlwZXByb3A6dGV4dHByb3A6Y2hlY2tlZDFzcGFjZTpwYWdlMDc0NjczOTM3NToxNnN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0cHJvcDpjaGVja2VkMnNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjE3c3lzOmlkc3lzOmZsYXZvdXJzeXM6Y2hpbGRyZW5wcm9wOnR5cGVwcm9wOnRleHRwcm9wOmNoZWNrZWQzc3BhY2U6cGFnZTA3NDY3MzkzNzU6MThzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnByb3A6dHlwZXByb3A6dGV4dHByb3A6Y2hlY2tlZDRzcGFjZTpwYWdlMDc0NjczOTM3NToxOXN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0cHJvcDpjaGVja2VkNXNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjIwc3lzOmlkc3lzOmZsYXZvdXJzeXM6Y2hpbGRyZW5wcm9wOnR5cGVwcm9wOnRleHRwcm9wOmNoZWNrZWQ2c3BhY2U6cGFnZTA3NDY3MzkzNzU6MjFzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnByb3A6dHlwZXByb3A6dGV4dHByb3A6Y2hlY2tlZDdzcGFjZTpwYWdlMDc0NjczOTM3NToyMnN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0cHJvcDpjaGVja2VkOHNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjIzc3lzOmlkc3lzOmZsYXZvdXJzeXM6Y2hpbGRyZW5wcm9wOnR5cGVwcm9wOnRleHRwcm9wOmNoZWNrZWQ5c3BhY2U6cGFnZTA3NDY3MzkzNzU6MjRzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnByb3A6dHlwZXByb3A6dGV4dHByb3A6Y2hlY2tlZDBzcGFjZTpwYWdlMDc0NjczOTM3NToyNXN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0cHJvcDpjaGVja2VkOXNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjI2c3lzOmlkc3lzOmZsYXZvdXJzeXM6Y2hpbGRyZW5wcm9wOnR5cGVwcm9wOnRleHRwcm9wOmNoZWNrZWQ4c3BhY2U6cGFnZTA3NDY3MzkzNzU6MjdzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnByb3A6dHlwZXByb3A6dGV4dHByb3A6Y2hlY2tlZDdzcGFjZTpwYWdlMDc0NjczOTM3NToyOHN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0cHJvcDpjaGVja2VkNnNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjI5c3lzOmlkc3lzOmZsYXZvdXJzeXM6Y2hpbGRyZW5wcm9wOnR5cGVwcm9wOnRleHRwcm9wOmNoZWNrZWQ1c3BhY2U6cGFnZTA3NDY3MzkzNzU6MzBzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnByb3A6dHlwZXByb3A6dGV4dHByb3A6Y2hlY2tlZDRzcGFjZTpwYWdlMDc0NjczOTM3NTozMXN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0cHJvcDpjaGVja2VkM3NwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjMyc3lzOmlkc3lzOmZsYXZvdXJzeXM6Y2hpbGRyZW5wcm9wOnR5cGVwcm9wOnRleHRwcm9wOmNoZWNrZWQyc3BhY2U6cGFnZTA3NDY3MzkzNzU6MzNzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnByb3A6dHlwZXByb3A6dGV4dHByb3A6Y2hlY2tlZDFzcGFjZTpwYWdlMDc0NjczOTM3NTozNHNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjM1c3lzOmlkc3lzOmZsYXZvdXJzeXM6Y2hpbGRyZW5wcm9wOnR5cGVwcm9wOnRleHRzcGFjZTpwYWdlMDc0NjczOTM3NTozNnN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0c3BhY2U6cGFnZTA3NDY3MzkzNzU6MzdzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnByb3A6dHlwZXByb3A6dGV4dHNwYWNlOnBhZ2UwNzQ2NzM5Mzc1OjM4c3lzOmlkc3lzOmZsYXZvdXJzeXM6Y2hpbGRyZW5wcm9wOnR5cGVwcm9wOnRleHRzcGFjZTpwYWdlMDc0NjczOTM3NTozOXN5czppZHN5czpmbGF2b3Vyc3lzOmNoaWxkcmVucHJvcDp0eXBlcHJvcDp0ZXh0c3BhY2U6cGFnZTA3NDY3MzkzNzU6NDBzeXM6aWRzeXM6Zmxhdm91cnN5czpjaGlsZHJlbnByb3A6dHlwZXByb3A6dGV4dAsMBgsMSQAMCwwLDAELDAYLDEkADAELDAYLDEkADAELDAYLDEkADAELDAYLDEkADAELDAYLDEkADAELDAYLDEkADAELDAYLDEkADAELDQYLDEkADAELDAYLDEkADAsMBgsMSQACCwwGCwxJAAILDAYLDEkAAgsMBgsMSQACCwwGCwxJAAILDAYLDEkAAgsMBgsMSQACCwwGCwxJAAILDAYLDEkAAgsNBgsMSQACCw0GCwxJAAIKBQIFSgAICxBLAAwODA4PSwAGCwkODAogSwAGCwxLAAYLDAlLDQwLDAsMCwwIAQIFRAAJRgAJSwIMCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwGCwxJAAwBCwwLDAYLDEkACwwGCwxJAAsMBgsMSQALDAYLDEkACwwGCwxJAAsMBgsMSQDTAQEAAAYBAQAAAQAABwEAAAcBAAAHAQAABwEAAAcBAAAHAQAABwEAAAgBAAAXAQAABQEAAAcBAAAHAQAABwEAAAcBAAAHAQAABwEAAAcBAAAHAQAABwEAAAcBAAADAQAACAEAAAYBAAACAQAABAEKAAwBAQAGAQAABgEAAAYBAAAGAQAABgEAAAYBAAAGAQAABgEAAAYBAAAGAQAABwEAAAcBAAAHAQAABwEAAAcBAAAHAQAABwEAAAcBAAAHAQEABQEAAAUBAAAFAQAABQEAAAUBAACnAQECAAECAAECAAECAAECAAECAAECAAECAAECQAEBAAJAGQEAAgEAAkABAQACQAEBAAJAAQEAAkABAQACQAEBAAJAAQEAAkABAQACQAEBAAJAAQEAAkACQQMAAgEAQQICAQIBAgECAQIBAgECAQIBAgECAAECQAABAkAAAQJAAAECQAABAkAAAQJAAAECQAABAkAAAQIAAQACAQACAQACAQACAQACAQACjwECQQYIQQMIQQECQQAGQQECAUIAAQZBXAIBAgECAQIBAgECAQIBAgECB0EHCUFVJQEoASIBqgEBKAGjBAG9AgGCBAG7BAGJAwE7QQsIQXgCQQYCAQJBBQIBAkEFAgECQQUCAQJBBgIBAkEFAgECQQUCAQJBBQJBAAJBAAdBAgJBBANBBARBBAVBBAZBBAdBAAOeAQB3DDM0NjcwMjQ2NDE6MHcLYWZmaW5lOmxpc3R3CGJ1bGxldGVkeXcMNzQ2NzM5Mzc1OjE1dww3NDY3MzkzNzU6MzN3DDc0NjczOTM3NTozNXcMNzQ2NzM5Mzc1OjM2dww3NDY3MzkzNzU6Mzd3DDc0NjczOTM3NTozOHcMNzQ2NzM5Mzc1OjM5dww3NDY3MzkzNzU6NDB3DDM0NjcwMjQ2NDE6M3cLYWZmaW5lOmxpc3R3CGJ1bGxldGVkeXcMMzQ2NzAyNDY0MTowdwwzNDY3MDI0NjQxOjR3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDM0NjcwMjQ2NDE6M3cMMzQ2NzAyNDY0MTo1dwthZmZpbmU6bGlzdHcIYnVsbGV0ZWR5dwwzNDY3MDI0NjQxOjR3DDM0NjcwMjQ2NDE6NncLYWZmaW5lOmxpc3R3CGJ1bGxldGVkeXcMMzQ2NzAyNDY0MTo1dwwzNDY3MDI0NjQxOjd3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDM0NjcwMjQ2NDE6NncMMzQ2NzAyNDY0MTo4dwthZmZpbmU6bGlzdHcIYnVsbGV0ZWR5dwwzNDY3MDI0NjQxOjd3DDM0NjcwMjQ2NDE6OXcLYWZmaW5lOmxpc3R3CGJ1bGxldGVkeXcMMzQ2NzAyNDY0MTo4dw0zNDY3MDI0NjQxOjEwdwthZmZpbmU6bGlzdHcIYnVsbGV0ZWR5dwwzNDY3MDI0NjQxOjl3DTM0NjcwMjQ2NDE6MTB3DlswLDAsNzIwLDExMDRdywEAdwwzMjc1NDg0MDM0OjB3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDMyNzU0ODQwMzQ6MHcNMzQ2NzAyNDY0MToxMHcMMzQ2NzAyNDY0MTo5dwwzMjc1NDg0MDM0OjB3DDM0NjcwMjQ2NDE6OXcMMzQ2NzAyNDY0MTo4dwwzMjc1NDg0MDM0OjB3DDM0NjcwMjQ2NDE6OHcMMzQ2NzAyNDY0MTo3dwwzMjc1NDg0MDM0OjB3DDM0NjcwMjQ2NDE6N3cMMzQ2NzAyNDY0MTo2dwwzMjc1NDg0MDM0OjB3DDM0NjcwMjQ2NDE6NncMMzQ2NzAyNDY0MTo1dwwzMjc1NDg0MDM0OjB3DDM0NjcwMjQ2NDE6NXcMMzQ2NzAyNDY0MTo0dwwzMjc1NDg0MDM0OjB3DDM0NjcwMjQ2NDE6NHcMMzQ2NzAyNDY0MTozdwwzMjc1NDg0MDM0OjB3DDM0NjcwMjQ2NDE6M3cMMzQ2NzAyNDY0MTowdwwzMjc1NDg0MDM0OjB3DDM0NjcwMjQ2NDE6MHcMNzQ2NzM5Mzc1OjE1dww3NDY3MzkzNzU6MzN3DDMyNzU0ODQwMzQ6MHcMNzQ2NzM5Mzc1OjM1dww3NDY3MzkzNzU6MzZ3DDc0NjczOTM3NTozN3cMNzQ2NzM5Mzc1OjM4dww3NDY3MzkzNzU6Mzl3DDc0NjczOTM3NTo0MHcMMzI3NTQ4NDAzNDoxdxBhZmZpbmU6cGFyYWdyYXBodwR0ZXh0dwwzMjc1NDg0MDM0OjF3DlswLDAsNzIwLDExMzZddwwzMjc1NDg0MDM0OjJ3EGFmZmluZTpwYXJhZ3JhcGh3BHRleHR3DDMyNzU0ODQwMzQ6MncMNzQ2NzM5Mzc1OjE1dww3NDY3MzkzNzU6MzN3DDMyNzU0ODQwMzQ6MXcMNzQ2NzM5Mzc1OjM1dww3NDY3MzkzNzU6MzZ3DDc0NjczOTM3NTozN3cMNzQ2NzM5Mzc1OjM4dww3NDY3MzkzNzU6Mzl3DDc0NjczOTM3NTo0MHcMMzI3NTQ4NDAzNDoydw5bMCwwLDcyMCwxMTY4XXcMMzI3NTQ4NDAzNDozdxBhZmZpbmU6cGFyYWdyYXBodwR0ZXh0dwwzMjc1NDg0MDM0OjN3DDMyNzU0ODQwMzQ6MncMMzI3NTQ4NDAzNDozdw5bMCwwLDcyMCwxMjAwXXcMMzI3NTQ4NDAzNDo0dxBhZmZpbmU6cGFyYWdyYXBodwR0ZXh0dwwzMjc1NDg0MDM0OjR3DDMyNzU0ODQwMzQ6M3cMMzI3NTQ4NDAzNDo0dw5bMCwwLDcyMCwxMjMyXXcMMzI3NTQ4NDAzNDo1dxBhZmZpbmU6cGFyYWdyYXBodwR0ZXh0dwwzMjc1NDg0MDM0OjV3DDMyNzU0ODQwMzQ6NHcMMzI3NTQ4NDAzNDo1dw5bMCwwLDcyMCwxMjY0XXcMMzI3NTQ4NDAzNDo2dxBhZmZpbmU6cGFyYWdyYXBodwR0ZXh0dwwzMjc1NDg0MDM0OjZ3DDMyNzU0ODQwMzQ6NXcMMzI3NTQ4NDAzNDo2dw5bMCwwLDcyMCwxMjk2XXcMMzI3NTQ4NDAzNDo3dxBhZmZpbmU6cGFyYWdyYXBodwR0ZXh0dwwzMjc1NDg0MDM0Ojd3DDMyNzU0ODQwMzQ6NncMMzI3NTQ4NDAzNDo3dw5bMCwwLDcyMCwxMzI4XXcMMzI3NTQ4NDAzNDo4dxBhZmZpbmU6cGFyYWdyYXBodwR0ZXh0dwwzMjc1NDg0MDM0Ojh3DDMyNzU0ODQwMzQ6N3cMMzI3NTQ4NDAzNDo4dw5bMCwwLDcyMCwxMzYwXXcMMzI3NTQ4NDAzNDo5dxBhZmZpbmU6cGFyYWdyYXBodwR0ZXh0dwwzMjc1NDg0MDM0Ojl3DDMyNzU0ODQwMzQ6OHcMMzI3NTQ4NDAzNDo5dw5bMCwwLDcyMCwxMzkyXXcNMzI3NTQ4NDAzNDoxMHcQYWZmaW5lOnBhcmFncmFwaHcEdGV4dHcNMzI3NTQ4NDAzNDoxMHcMMzI3NTQ4NDAzNDo5dw0zMjc1NDg0MDM0OjEwdw5bMCwwLDcyMCwxNDI0XXcNMzI3NTQ4NDAzNDoxMXcQYWZmaW5lOnBhcmFncmFwaHcEdGV4dHcNMzI3NTQ4NDAzNDoxMXcNMzI3NTQ4NDAzNDoxMHcNMzI3NTQ4NDAzNDoxMXcOWzAsMCw3MjAsMTQ1Nl2fAwB3BXBhZ2UwdwB7Qnhs6prDgAB9AX0BfQJ9AX0BfQF9AX0BfQF3Czc0NjczOTM3NTowdwthZmZpbmU6cGFnZXcLNzQ2NzM5Mzc1OjF3DmFmZmluZTpzdXJmYWNldws3NDY3MzkzNzU6MncMYWZmaW5lOmZyYW1ldws3NDY3MzkzNzU6MncBMHcCYTB3BXNoYXBldw1bMCwwLDEwMCwxMDBddwRyZWN0fQB5dwcjZmZmZmZmfQR3ByMwMTAxMDF3BXNvbGlkdww3NDY3MzkzNzU6MTV3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDc0NjczOTM3NToxNncLYWZmaW5lOmxpc3R3CGJ1bGxldGVkeXcMNzQ2NzM5Mzc1OjE3dwthZmZpbmU6bGlzdHcIYnVsbGV0ZWR5dww3NDY3MzkzNzU6MTh3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDc0NjczOTM3NToxOXcLYWZmaW5lOmxpc3R3CGJ1bGxldGVkeXcMNzQ2NzM5Mzc1OjIwdwthZmZpbmU6bGlzdHcIYnVsbGV0ZWR5dww3NDY3MzkzNzU6MjF3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDc0NjczOTM3NToyMncLYWZmaW5lOmxpc3R3CGJ1bGxldGVkeXcMNzQ2NzM5Mzc1OjIzdwthZmZpbmU6bGlzdHcIYnVsbGV0ZWR5dww3NDY3MzkzNzU6MjR3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDc0NjczOTM3NToyNXcLYWZmaW5lOmxpc3R3CGJ1bGxldGVkeXcMNzQ2NzM5Mzc1OjI0dww3NDY3MzkzNzU6MjZ3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDc0NjczOTM3NToyM3cMNzQ2NzM5Mzc1OjI1dww3NDY3MzkzNzU6Mjd3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDc0NjczOTM3NToyMncMNzQ2NzM5Mzc1OjI2dww3NDY3MzkzNzU6Mjh3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDc0NjczOTM3NToyMXcMNzQ2NzM5Mzc1OjI3dww3NDY3MzkzNzU6Mjl3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDc0NjczOTM3NToyMHcMNzQ2NzM5Mzc1OjI4dww3NDY3MzkzNzU6MzB3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDc0NjczOTM3NToxOXcMNzQ2NzM5Mzc1OjI5dww3NDY3MzkzNzU6MzF3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDc0NjczOTM3NToxOHcMNzQ2NzM5Mzc1OjMwdww3NDY3MzkzNzU6MzJ3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDc0NjczOTM3NToxN3cMNzQ2NzM5Mzc1OjMxdww3NDY3MzkzNzU6MzN3C2FmZmluZTpsaXN0dwhidWxsZXRlZHl3DDc0NjczOTM3NToxNncMNzQ2NzM5Mzc1OjMydww3NDY3MzkzNzU6MzV3EGFmZmluZTpwYXJhZ3JhcGh3Amgxdww3NDY3MzkzNzU6MzZ3EGFmZmluZTpwYXJhZ3JhcGh3Amgydww3NDY3MzkzNzU6Mzd3EGFmZmluZTpwYXJhZ3JhcGh3Amgzdww3NDY3MzkzNzU6Mzh3EGFmZmluZTpwYXJhZ3JhcGh3Amg0dww3NDY3MzkzNzU6Mzl3EGFmZmluZTpwYXJhZ3JhcGh3Amg1dww3NDY3MzkzNzU6NDB3EGFmZmluZTpwYXJhZ3JhcGh3Amg2A4GymvUMHQABAwADNwEAAwADBQEAAwADBQEAAwADBQEAAwADBQEAAwADBQEAAwADBQEAAwADBQEAAwADAAEDAQCC1%2B%2BZDDMABwIDAgMCAwIDAgMCAwIDAgMCCgMAAgACAAMAAgEKAQIAAwACAQIBAgADAAIBAgECAAMAAgECAQIAAwACAQIBAgADAAIBAgECAAMAAgECAQIAAwACAQIBAgADAAIBAgECAAMAAgCvrYnkAlU9AQGsDA0JAwADAQQAAwUBAAMAAwUBAAMAAwUBAAMAAwUBAAMAAwUBAAMAAwUBAAMAAwUBAAMAAwUBAAMAAwABAwEAAwADAAMEBAADAAQCAQADAAMABAIBAAMAAwAEAgEAAwADAAQEBAADAAQCAQADAAMABAIBAAMAAwAEAgEAAwADAAMDAQgEAAECAQAEAAEDAQAEAAEEAQAEAAEFAQAEAAEGAQAEAAEHAQA%3D

@codesandbox
Copy link

codesandbox bot commented Mar 6, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Mar 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 9:13AM (UTC)
blocksuite-react ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 9:13AM (UTC)

@fundon fundon marked this pull request as draft March 6, 2023 23:45
@doodlewind doodlewind self-assigned this Mar 7, 2023
@fundon fundon force-pushed the refactor/use-document.elementFromPoint-to-find-block branch from beaabbf to 9716f77 Compare March 7, 2023 08:50
@doodlewind doodlewind changed the title refactor: use document.elementsFromPoint to find block refactor(selection): switch to document.elementsFromPoint Mar 14, 2023
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's land this feat!

@doodlewind doodlewind merged commit 36d5097 into toeverything:master Mar 14, 2023
@fundon fundon deleted the refactor/use-document.elementFromPoint-to-find-block branch March 14, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants