feat(edgeless): component toolbar #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alt1o
force-pushed
the
feat/edgeless-edit-bar
branch
from
ac9af0d
to
3a907ee
Compare
alt1o
force-pushed
the
feat/edgeless-edit-bar
branch
from
aed279b
to
499214a
Compare
doodlewind
reviewed
Mar 16, 2023
| @@ -0,0 +1,11 @@ | |||
| export function simplePick<T extends object, K extends keyof T>( | |||
There was a problem hiding this comment.
Admittedly couldn't find a better place for this
doodlewind
reviewed
Mar 16, 2023
| this.surface.removeElement(element.id); | ||
| } | ||
| }); | ||
| this.page.captureSync(); |
There was a problem hiding this comment.
I don't think we should do captureSync() twice. Having it before operations should be adequate.
|
CI only fails at uploading Codecov, good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1701
fix #1733
2023-03-16.19.26.02.mov