Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use typescript@5 const type param for matchFlavours #1786

Merged
merged 14 commits into from
Apr 28, 2023
Merged

refactor: use typescript@5 const type param for matchFlavours #1786

merged 14 commits into from
Apr 28, 2023

Conversation

Saul-Mirone
Copy link
Collaborator

No description provided.

@codesandbox
Copy link

codesandbox bot commented Mar 20, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Mar 20, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 5:58am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 5:58am
blocksuite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 5:58am

@doodlewind doodlewind added the blocked PR is disallowed to merge due to some reasons label Mar 20, 2023
@doodlewind
Copy link
Member

Wait for upstream TS 5.0 support from playwright

@Saul-Mirone
Copy link
Collaborator Author

Seems playwright has upgraded the typescript version. We need to wait for them to release the changes.

microsoft/playwright#21900

@himself65 himself65 enabled auto-merge (squash) March 25, 2023 05:40
@himself65 himself65 disabled auto-merge March 25, 2023 05:56
@himself65 himself65 removed the blocked PR is disallowed to merge due to some reasons label Mar 25, 2023
@doodlewind doodlewind added the blocked PR is disallowed to merge due to some reasons label Apr 7, 2023
@Saul-Mirone
Copy link
Collaborator Author

Update: still waiting for @playwright/test@1.33.0.

@himself65
Copy link
Contributor

https://github.com/microsoft/playwright/releases/tag/v1.33.0

@Saul-Mirone Saul-Mirone mentioned this pull request Apr 28, 2023
Closed
@Saul-Mirone Saul-Mirone merged commit 4bed88f into toeverything:master Apr 28, 2023
12 checks passed
@Saul-Mirone Saul-Mirone deleted the use-new-const-type-param branch April 28, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

Assignees

@Saul-Mirone Saul-Mirone

Labels
blocked PR is disallowed to merge due to some reasons
Projects
AFFiNE Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Saul-Mirone @doodlewind @himself65