Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(database): remove mode in crdt model #1918

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Conversation

doodlewind
Copy link
Member

@doodlewind doodlewind commented Apr 2, 2023

@himself65 @zqran I suggest we should not writing the mode into database block model, it's redundant and changing it will create unnecessary undo/redo actions.

@codesandbox
Copy link

codesandbox bot commented Apr 2, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Apr 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2023 0:27am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2023 0:27am
blocksuite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2023 0:27am

@doodlewind doodlewind merged commit c2c0439 into master Apr 2, 2023
16 checks passed
@doodlewind doodlewind deleted the 0402/database branch April 2, 2023 00:48
@doodlewind doodlewind added the breaking Contains breaking change that must be addressed label Apr 2, 2023
@doodlewind doodlewind mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Contains breaking change that must be addressed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants