refactor(database): flatten internalProperty and property
#1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
doodlewind
commented
Apr 2, 2023
| @@ -134,8 +134,8 @@ jobs: | |||
| - name: Install playwright browsers | |||
| run: npx playwright install chromium | |||
|
|
|||
| - name: Run virgo playwright test | |||
| run: pnpm --filter=@blocksuite/virgo test:e2e | |||
| # - name: Run virgo playwright test | |||
There was a problem hiding this comment.
@Flrande @Saul-Mirone I temporally disabled virgo e2e tests since it keeps failing on CI, hope for help re-enabling it!
doodlewind
commented
Apr 2, 2023
| @@ -33,16 +33,11 @@ export class DatabaseBlockService extends BaseService<DatabaseBlockModel> { | |||
|
|
|||
| // default column | |||
| const tagColumnId = page.updateColumnSchema({ | |||
There was a problem hiding this comment.
/cc @zqran @himself65 see here for the simplified API
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.