feat(selection): support scroll wheel to move dragging blocks #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fundon
changed the title
fundon
force-pushed
the
feat/support-dragging-blocks-on-scrolling-wheel
branch
2 times, most recently
from
9865cd9
to
9cd0a10
Compare
fundon
force-pushed
the
feat/support-dragging-blocks-on-scrolling-wheel
branch
from
6bfccc9
to
e638de5
Compare
fundon
force-pushed
the
feat/support-dragging-blocks-on-scrolling-wheel
branch
from
2443d36
to
b48cdb5
Compare
|
Included #1310 |
|
Included #1164 |
doodlewind
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
I suggest having some further refactoring on selection for decoupling (making the selection-related components pluggable for the editor) and better reusability, since its complexity grows fast. Will discuss with @fundon for more plannings, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-04-10.at.10.55.06.AM.mov