Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(database): column header #1987

Merged
merged 3 commits into from
Apr 8, 2023

Conversation

zqran
Copy link
Sponsor Member

@zqran zqran commented Apr 8, 2023

This pr mainly contains the following changes

  1. Directory structure
.
├── column-header
│   ├── column-header.ts
│   ├── column-move
│   │   ├── column-drag-indicator.ts
│   │   ├── column-drag-preview.ts
│   │   └── index.ts
│   ├── column-width
│   │   └── index.ts
│   └── styles.ts
  1. Encapsulation of two functions
    2.1 initChangeColumnWidthHandlers is used to handle changing the column width
    2.2 initMoveColumnHandlers is used to handle drag and drop to change the column order

part of: #629

@codesandbox
Copy link

codesandbox bot commented Apr 8, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Apr 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2023 6:05am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2023 6:05am
blocksuite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2023 6:05am

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@doodlewind doodlewind merged commit d74e3e2 into toeverything:master Apr 8, 2023
10 checks passed
@zqran zqran deleted the refactor-db-column-header branch April 8, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants