feat(selection): support triple-click to select all text of block #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fundon
commented
Apr 12, 2023
| @@ -309,6 +310,14 @@ export class DefaultSelectionManager { | |||
| showFormatQuickBarByDoubleClick(e, this.page, this.container, this.state); | |||
| }; | |||
|
|
|||
| private _onContainerTripleClick = (e: SelectionEvent) => { | |||
There was a problem hiding this comment.
@lawvs You can add the logic of all the text of the block in this method.
There was a problem hiding this comment.
It mainly shows the logic of format-quick-bar and whether the content is correct when copying.
fundon
force-pushed
the
feat/support-tripleclick
branch
from
ad1f361
to
fb3b8a5
Compare
fundon
force-pushed
the
feat/support-tripleclick
branch
from
fb3b8a5
to
4eeabb9
Compare
fundon
force-pushed
the
feat/support-tripleclick
branch
from
4eeabb9
to
d3e2b4e
Compare
fundon
force-pushed
the
feat/support-tripleclick
branch
from
d3e2b4e
to
abf4426
Compare
fundon
force-pushed
the
feat/support-tripleclick
branch
from
7f33141
to
ab6ed9a
Compare
fundon
force-pushed
the
feat/support-tripleclick
branch
from
ab6ed9a
to
83fa11e
Compare
doodlewind
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #2036
Screen.Recording.2023-04-14.at.5.19.23.PM.mov