Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: init new blob storage #2169

Merged
merged 44 commits into from
Apr 20, 2023
Merged

feat: init new blob storage #2169

merged 44 commits into from
Apr 20, 2023

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Apr 19, 2023 •
edited

Fixes: #1940, #2147

Usage

const blobStorages = [createMemoryStorage(id), createIndexeddbStorage(id)]

Known issue:

  • Blob syncing state has been lost, need to be rewritten in AFFiNE side
  • Indexeddb Test has been lost, need to be rewritten in new logic

@codesandbox
Copy link

codesandbox bot commented Apr 19, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Apr 19, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 6:03am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 6:03am
blocksuite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 6:03am

@doodlewind
Copy link
Member

It looks good to deprecate and remove the IndexedDB blob storage test, they are staled and not checked in CI for now.

@doodlewind doodlewind enabled auto-merge (squash) April 20, 2023 05:52
@himself65
Copy link
Contributor Author

himself65 commented Apr 20, 2023 •
edited

It looks good to deprecate and remove the IndexedDB blob storage test, they are staled and not checked in CI for now.

I see we check the image status in existing playwright, so it's okay to remove it

@himself65 himself65 removed the blocked PR is disallowed to merge due to some reasons label Apr 20, 2023
@doodlewind doodlewind merged commit b869981 into master Apr 20, 2023
11 checks passed
@doodlewind doodlewind deleted the himself65/0419-blob branch April 20, 2023 06:11
@doodlewind doodlewind mentioned this pull request Apr 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengx17 pengx17 pengx17 approved these changes

@doodlewind doodlewind doodlewind approved these changes

Assignees

@himself65 himself65

Labels
None yet
Projects
AFFiNE Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor blob storage
3 participants
@himself65 @doodlewind @pengx17