Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(selection): support shift-click #2280

Merged
merged 5 commits into from
Apr 26, 2023
Merged

feat(selection): support shift-click #2280

merged 5 commits into from
Apr 26, 2023

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Apr 25, 2023

Related to: #1453

  • native: select texts
  • block: select blocks
  • tests

@codesandbox
Copy link

codesandbox bot commented Apr 25, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 2:48am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 2:48am

@fundon fundon marked this pull request as draft April 25, 2023 09:53
@Flrande
Copy link
Member

Flrande commented Apr 26, 2023

It looks like we need to select at least one character before we can use shift + click to select multiple lines at once, and if we just have a collapsed selection, shift + click won't work.

select.mp4

@fundon
Copy link
Contributor Author

fundon commented Apr 26, 2023

@Flrande fixed

@doodlewind doodlewind merged commit 7aaf1b4 into master Apr 26, 2023
12 checks passed
@doodlewind doodlewind deleted the feat/shift_click branch April 26, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants