Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store user can't define own root flavor #2292

Merged
merged 2 commits into from
Apr 26, 2023
Merged

fix: store user can't define own root flavor #2292

merged 2 commits into from
Apr 26, 2023

Conversation

zzj3720
Copy link
Member

@zzj3720 zzj3720 commented Apr 26, 2023

I'm using the @blocksuite/store separately and stuck with this bug.

@codesandbox
Copy link

codesandbox bot commented Apr 26, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 7:02am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 7:02am

@doodlewind doodlewind merged commit d240f34 into toeverything:master Apr 26, 2023
12 checks passed
@Saul-Mirone
Copy link
Collaborator

Saul-Mirone commented Apr 26, 2023

@doodlewind we need to revert this commit because this will break current database block. For now we have two root blocks: affine:surface and affine:page. The code will mark isRoot as true for both of them. The final solution will be provided by #2320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants