Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple editor instance on the same page #2406

Merged
merged 11 commits into from
May 5, 2023
Merged

feat: support multiple editor instance on the same page #2406

merged 11 commits into from
May 5, 2023

Conversation

zzj3720
Copy link
Member

@zzj3720 zzj3720 commented May 4, 2023

related #2396

  • Added an active state to the editor instance, only active editor can receive hotkey events.
  • Only the virgo editor in the active editor can be focused
  • Refactor tests to support automatically use in multiple editor instance scenarios after test cases been written.

@codesandbox
Copy link

codesandbox bot commented May 4, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 8:38am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 8:38am

# Conflicts:
#	packages/blocks/src/database-block/table/components/column-type/rich-text.ts
@zzj3720
Copy link
Member Author

zzj3720 commented May 5, 2023

@doodlewind Should I put other changes in a separate PR? I feel like this PR already contains too many code changes, which may make it difficult to review.

@doodlewind
Copy link
Member

@doodlewind Should I put other changes in a separate PR? I feel like this PR already contains too many code changes, which may make it difficult to review.

Would be great to split more PRs, thanks!

@zzj3720 zzj3720 marked this pull request as ready for review May 5, 2023 09:05
@zzj3720
Copy link
Member Author

zzj3720 commented May 5, 2023

Currently, only basic.spec.ts has been passed.
I will complete the remaining parts in other PRs.

@zzj3720
Copy link
Member Author

zzj3720 commented May 5, 2023

@doodlewind Should I put other changes in a separate PR? I feel like this PR already contains too many code changes, which may make it difficult to review.

Would be great to split more PRs, thanks!

@doodlewind Does this PR need to be split into smaller ones?

@Flrande
Copy link
Member

Flrande commented May 5, 2023

@doodlewind Does this PR need to be split into smaller ones?

I am reviewing this PR. :)

@Flrande Flrande merged commit 81143df into toeverything:master May 5, 2023
13 checks passed
@himself65
Copy link
Contributor

I found a regression on AFFiNE that would cause page is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants