fix: select texts when clicking on blank area #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I was unable to reproduce the problem in #2447 and need some time to confirm whether this fix is correct. |
* master: fix: support dragging block to blank (toeverything#2469)
fundon
commented
May 9, 2023
packages/virgo/src/services/event.ts
Outdated
| this._editor.rangeService.setVRange({ | ||
| index: this._editor.yText.length, | ||
| length: range.endOffset, | ||
| }); |
There was a problem hiding this comment.
@Flrande When backward(↑) selection, the cursor will jump, start <-> end, very unstable, so changed to the current
There was a problem hiding this comment.
What is the value of native range in this case? It seems that this change will make vRange overflow because the index has been reached max value (this._editor.yText.length).
Flrande
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2447