refactor(phasor): make yjs as the single of truth #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
doodlewind
approved these changes
May 11, 2023
|
Great progress, hope to see more tractions in Phasor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preceding steps for #2441
An element in phasor corresponds to a
SurfaceElementand aYElement, the renderer is essentially controlled by theSurfaceElement, andsurface.tsimplements a two-way binding between theSurfaceElementand theYElement. This creates a lot of code for mutual transformation and synchronization between them which is confusing for readers and difficult for maintenance, and also prone to collaborative bugs, because yjs is not the single of truth in essence.For this reason, the following refactoring was done, removing
YElementfrom the original code and addingY.Mapfield to theSurfaceElement.