Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: item in the middle of a unordered list disappears when backspace #2506

Merged
merged 6 commits into from
May 11, 2023
Merged

fix: item in the middle of a unordered list disappears when backspace #2506

merged 6 commits into from
May 11, 2023

Conversation

zuoxiaodong0815
Copy link
Contributor

@zuoxiaodong0815 zuoxiaodong0815 commented May 10, 2023 •
edited

close #2461

@codesandbox
Copy link

codesandbox bot commented May 10, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented May 10, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 2:17am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 2:17am

@doodlewind doodlewind changed the title fix: fix: item in the middle of a unordered list disappears when backspace fix: item in the middle of a unordered list disappears when backspace May 10, 2023
@zuoxiaodong0815
Copy link
Contributor Author

I think this behaviour about #1881 is normal, so I roll back the code.

@zuoxiaodong0815 zuoxiaodong0815 marked this pull request as ready for review May 11, 2023 02:03
@zuoxiaodong0815 zuoxiaodong0815 enabled auto-merge (squash) May 11, 2023 02:06
@zuoxiaodong0815 zuoxiaodong0815 merged commit 079a26c into toeverything:master May 11, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@zuoxiaodong0815 zuoxiaodong0815

Labels
None yet
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Item in the middle of a unordered list disappears when delete its format
2 participants
@zuoxiaodong0815 @doodlewind