Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edgeless): switch to pan mode when holding right-key #2512

Merged
merged 1 commit into from
May 10, 2023

Conversation

fundon
Copy link
Contributor

@fundon fundon commented May 10, 2023

Related to: #2432

Screen.Recording.2023-05-10.at.8.53.21.PM.mov

@codesandbox
Copy link

codesandbox bot commented May 10, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@fundon fundon requested a review from doodlewind May 10, 2023 12:50
@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 0:53am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 0:53am

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great enhancement!

@doodlewind
Copy link
Member

Please write close #2432 in PR description next time, so that auto closing could work.

@doodlewind doodlewind merged commit c3adecb into toeverything:master May 10, 2023
13 checks passed
@fundon fundon deleted the 0510-switch-to-pan branch May 11, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants