refactor(store): change editor structure to single root block #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Saul-Mirone
force-pushed
the
migrate-to-single-root
branch
from
f7a115a
to
7d525c4
Compare
doodlewind
reviewed
May 12, 2023
There was a problem hiding this comment.
This would require migration (e.g., trying to export YDoc from https://blocksuite-toeverything.vercel.app/?init and import locally).
Saul-Mirone
commented
May 16, 2023
| @@ -174,6 +174,56 @@ const migrations: Migration[] = [ | |||
| } | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
@doodlewind Does this migration look good to you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves surface block into children of page block and keeps the editor has single root.