feat(database): support row-level selection #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…nto 0512-db-selection
zqran
changed the title
…nto 0512-db-selection
Saul-Mirone
reviewed
May 15, 2023
| @@ -447,6 +455,18 @@ export class DefaultPageBlockComponent | |||
| slots.embedEditingStateUpdated.on(embedEditingState => { | |||
| this._embedEditingState = embedEditingState; | |||
| }); | |||
| slots.databaseTableUpdated.on(state => { | |||
There was a problem hiding this comment.
Can you move this slot into database model?
Saul-Mirone
reviewed
May 15, 2023
| @@ -539,6 +539,24 @@ export function createDragHandle(pageBlock: DefaultPageBlockComponent) { | |||
| pageBlock.selection.state.type = dragging ? 'block:drag' : 'block'; | |||
| }, | |||
| setSelectedBlock(modelState: EditingState | null) { | |||
| if (modelState) { | |||
There was a problem hiding this comment.
Instead of handle database selection here, maybe we can move this into database service.
|
I really like this idea |
Saul-Mirone
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #2468
alo close: #2467
2023-05-15.10.09.45.mov