Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inline code or strikethrough error when hard enter #2642

Merged
merged 1 commit into from
May 19, 2023

Conversation

fourdim
Copy link
Contributor

@fourdim fourdim commented May 18, 2023

@codesandbox
Copy link

codesandbox bot commented May 18, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 8:08am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 8:08am

Copy link

@affine-bot affine-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution.

In order for us to review and merge your suggested changes, please sign our CLA at https://github.com/toeverything/blocksuite/edit/master/.github/CLA.md

Copy link
Member

@lawvs lawvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Could you add some tests for it?

@fourdim
Copy link
Contributor Author

fourdim commented May 18, 2023

Nice catch! Could you add some tests for it?

I'm sorry but I'm quite busy now. And I'm also not familiar with the playwright test.

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to land this, thanks!

@doodlewind doodlewind merged commit 5986137 into toeverything:master May 19, 2023
14 checks passed
@fourdim fourdim deleted the fix-code-hardenter branch July 11, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

[issues] image resize and inline block
4 participants