Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edgeless): edgless element drag snap #2967

Merged
merged 18 commits into from
Jun 13, 2023
Merged

feat(edgeless): edgless element drag snap #2967

merged 18 commits into from
Jun 13, 2023

Conversation

regischen
Copy link
Member

@regischen regischen commented Jun 2, 2023 •
edited

Closes #2440
It is the design draft of edgeless element snap.
there are two things necessarily to be viewd. @doodlewind

  1. the API of EdgelessSnapManager and how it can be used.
  2. I add mechanism to allow renderer to render non-phaserElement.

@regischen regischen requested a review from doodlewind June 2, 2023 08:02
@codesandbox
Copy link

codesandbox bot commented Jun 2, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Jun 2, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 4:48am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 4:48am

@doodlewind doodlewind self-assigned this Jun 2, 2023
@regischen regischen force-pushed the feat-edgeless-element-snap branch 2 times, most recently from eae7805 to a070276 Compare June 6, 2023 09:26
@regischen regischen marked this pull request as ready for review June 9, 2023 02:54
doodlewind
doodlewind approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this critical functionality!

@doodlewind doodlewind enabled auto-merge (squash) June 13, 2023 04:50
@doodlewind doodlewind merged commit 8ecfc3d into master Jun 13, 2023
18 checks passed
@doodlewind doodlewind deleted the feat-edgeless-element-snap branch June 13, 2023 04:53
@regischen
Copy link
Member Author

LGTM, thanks for adding this critical functionality!

Also thanks for greatly improving quality of these codes!
now it fits more naturally into the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@doodlewind doodlewind

@regischen regischen

Labels
None yet
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support snap in whiteboard
2 participants
@regischen @doodlewind