feat: add block on clicking page bottom when necessary #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
QiShaoXuan
commented
Jun 9, 2023
•
QiShaoXuan
commented
- if click bottom of page and the end block is embed, editor should insert a new editable block
- if click bottom of page and the end block is editable, the last editable block should be focused
…d insert a new editable block
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
QiShaoXuan
changed the title
doodlewind
approved these changes
Jun 9, 2023
doodlewind
changed the title
lawvs
reviewed
Jun 9, 2023
| return pageBlock?.getBoundingClientRect() || null; | ||
| }); | ||
|
|
||
| assert(pageRect !== null); |
There was a problem hiding this comment.
You should use expect from playwright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.