Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pressing esc to select blocks #3035

Conversation

donteatfriedrice
Copy link
Member

To close #2893
Feat:

  1. Press esc to select single block.
  2. Press esc to select multiple blocks when having multiple native range block selection.
  3. Press esc to unselect blocks when block is selected.
support-pressing-esc-to-select-blocks.mov

@codesandbox
Copy link

codesandbox bot commented Jun 9, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2023 3:01am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2023 3:01am

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping us on such features! Hope this can go pass the CI :)

@doodlewind doodlewind enabled auto-merge (squash) June 10, 2023 02:17
auto-merge was automatically disabled June 10, 2023 03:00

Head branch was pushed to by a user without write access

@doodlewind doodlewind merged commit 61ce15f into toeverything:master Jun 13, 2023
18 checks passed
@donteatfriedrice donteatfriedrice deleted the feat/support-pressing-escape-to-select-blocks branch June 14, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Support pressing esc to select single block using block-level selection
2 participants