Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export two adjacent bookmarks produce one invalid url #3055

Conversation

donteatfriedrice
Copy link
Member

To fix #2938

export-bookmark-to-markdown.mov

The previous Bookmark block2html service just return the url of bookmark block.
Can bookmarks be considered as links and return the link in bookmark service?

@codesandbox
Copy link

codesandbox bot commented Jun 12, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 9:43am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 9:43am

@donteatfriedrice
Copy link
Member Author

The export output
bookmark-markdown-export

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good catch, thanks!

@doodlewind doodlewind merged commit 90221f5 into toeverything:master Jun 12, 2023
20 checks passed
@donteatfriedrice donteatfriedrice deleted the fix/export-two-adjacent-bookmark-to-markdown-produces-one-invalid-concated-url branch June 12, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Export two adjacent bookmark to markdown produces one invalid concated URL
2 participants