Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edgeless): support note clipping #3314

Merged
merged 10 commits into from
Jul 5, 2023
Merged

feat(edgeless): support note clipping #3314

merged 10 commits into from
Jul 5, 2023

Conversation

doouding
Copy link
Member

@doouding doouding commented Jul 4, 2023

close #3136, #3084

@codesandbox
Copy link

codesandbox bot commented Jul 4, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 4:35am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 4:35am

@doouding
Copy link
Member Author

doouding commented Jul 4, 2023

Some tests did not pass, but it seems that it was not caused by this feature(they failed on master branch too). Should I fix them as well?

@doouding doouding marked this pull request as ready for review July 5, 2023 03:56
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally fits our coding style, thanks for the feat!

@doodlewind doodlewind merged commit b7c5abd into master Jul 5, 2023
17 of 19 checks passed
@doodlewind doodlewind deleted the feat/note-clipping branch July 5, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Support clipping of notes
2 participants