Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports copying images and cross app pasting #3318

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Jul 4, 2023

closes: #1468, #3056

@codesandbox
Copy link

codesandbox bot commented Jul 4, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 8:59am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 8:59am

@@ -329,65 +327,6 @@ function getBlockAndRect(blocks: BaseBlockModel[], mid: number) {
};
}

export async function downloadImage(model: BaseBlockModel) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for help migrating legacy utils!

@doodlewind doodlewind changed the title feat: supports copying images and can be pasted into other apps feat: supports copying images and cross app pasting Jul 4, 2023
@doodlewind doodlewind enabled auto-merge (squash) July 4, 2023 07:54
@doodlewind doodlewind merged commit 24c26ae into toeverything:master Jul 4, 2023
17 of 19 checks passed
@fundon fundon deleted the copy-image branch July 4, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Unable to paste copied image outside of BlockSuite
2 participants