-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(edgeless): support connecting rotated elements #3394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
regischen
changed the title
feat: connector connects rotated elements
feat(edgeless): connector connects rotated elements
Jul 6, 2023
regischen
changed the title
feat(edgeless): connector connects rotated elements
fix(edgeless): connector connects rotated elements
Jul 6, 2023
doodlewind
changed the title
fix(edgeless): connector connects rotated elements
feat(edgeless): support connecting rotated elements
Jul 6, 2023
doodlewind
reviewed
Jul 6, 2023
doodlewind
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support connector connects rotated elements.
And considering slope.
Screen.Recording.2023-07-06.at.14.16.05.mov
Also support triangle and diamond.
Screen.Recording.2023-07-06.at.14.19.17.mov
TODO: support connects ellipsis edges. now only can connect anchors.